Don't kill me...
Very possible this will break stuff...

CommentFileSizeAuthor
#9 1772098-camelcase-9.patch55.9 KBaspilicious
#8 camelcase_cleanup.patch58.58 KBaspilicious
xjm-dont-kill-me.patch62.39 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

If it would be marked as needs review you would get a RTBC.

+++ b/lib/Drupal/views/Tests/UpgradeTestCase.phpundefined
@@ -55,7 +55,7 @@ class UpgradeTestCase extends ViewTestBase {
   function debugField($field) {

maybe it makes sense to remove this test-code

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Active » Needs review

Lets just review it.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

maybe it makes sense to remove this test-code

Not in this issue please. We need to go over *every* views file in the end to remove garbage like this. So this would be a nice job for that.

Hmmm but maybe we forget to remove it than...

Btw: patch is green...

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Reviewed & tested by the community

So it's RTBC

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

Yep, looks good to me too. Apart from all that junk at the top of the patch ;)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

xjm-dont-kill-me.patch queued for re-testing.

Status: Reviewed & tested by the community » Needs work

The last submitted patch, xjm-dont-kill-me.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
camelcase_cleanup.patch58.58 KB

Lots is changed...
Lets see if it works...

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1772098-camelcase-9.patch55.9 KB

Reroll...

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed
Issue tags: +VDC

Please always add the VDC tag, as it allows to load the issues much faster :p

Automatically closed -- issue fixed for 2 weeks with no activity.