While working on a patch for http://drupal.org/node/165140 I noticed that update.php prints out a message about "All errors have been logged." where "logged" is currently a broken link to admin/logs/watchdog.
Attached patch checks if dblog module is enabled, and if so, makes the word a link to admin/logs/dblog. If dblog isn't installed, there's really no valid path we can link to, so the sentence is just printed without a link. Also, the "You may need to check the watchdog
table manually." sentence is conditionally printed only if dblog is enabled.
Figured it was better to keep this a separate patch/issue than cramming it into #165140.
Comment | File | Size | Author |
---|---|---|---|
#3 | update_dblog_link.patch_2.txt | 1.93 KB | dww |
update_dblog_link.patch.txt | 1.91 KB | dww |
Comments
Comment #1
hass CreditAttribution: hass commentedLinks like
index.php?q=admin/logs/dblog
are not correctly build. Useurl('admin/logs/dblog')
to make sure they will work with a basepath, too.Comment #2
dwwThat's how the code was originally, I was just shuffling it around and fixing the path. But sure, good point, I might as well fix the other ways it was broken, too. Stay tuned.
Comment #3
dwwFYI: CVS archeology leads to http://drupal.org/node/48215 and http://drupal.org/node/49501 as the origin of the existing links.
Also, please note that url() and l() would get this wrong, since then the links would point to update.php, not index.php, as explained by this comment, only a few lines higher:
Anyway, here's a new patch that includes my fixes above, and finishes the job UnConeD started in #49501.
p.s. @hass: since you mentioned it in the other issue, I should explain that *none* of these are translatable strings, since t() isn't used anywhere in update.php.
Comment #4
Gábor HojtsyLooks good, thanks, committed.
Comment #5
(not verified) CreditAttribution: commented