I want to be able to allow people using the field to paste in their soundcloud artist page and get a set of their music, making it a bit more flexible then just a track or a set link.

For example pasting in http://soundcloud.com/mrbillstunes will give a set of all Mr Bills tunes.

I've already fixed this in the dev version and am now making a patch. I've never done this before, hopefully it goes well.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Chappo’s picture

Status: Active » Needs review
FileSize
2.63 KB

Here is the patch, I swapped the order of the 'if' around and added an isset clause so that if there is no 2nd part of the url we treat it as a set.

Chappo’s picture

Assigned: Chappo » Unassigned
attila.fekete’s picture

Assigned: Unassigned » attila.fekete

Hi,
that could be a good idea to implement such a feature, i'll check your patch. Thanks

kingfisher64’s picture

For the latest stable version and the 7.x-1.x-dev dated the 11th March 2013 applying the patch in #1 outputs:

$ patch < soundcloudfield-Added_support_for_artists_page-1766184-1.patch
patch unexpectedly ends in middle of line
patch: **** Only garbage was found in the patch input.

attila.fekete’s picture

Issue summary: View changes
Status: Needs review » Fixed

@Chappo: thanks for the patch. With a slight change I applied your code to latest dev.

--
http://drupalcode.org/project/soundcloudfield.git/commitdiff/086c32151d5...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.

  • Commit 086c321 on 7.x-1.x, 8.x-1.x by attila.fekete:
    Issue #1766184 by Chappo, attila.fekete: support artist pages