self explanatory; patch to follow.

CommentFileSizeAuthor
#1 1765026.patch50.2 KBdamiankloip
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Active » Needs review
FileSize
1765026.patch50.2 KB

Let's try this.

Status: Needs review » Needs work

The last submitted patch, 1765026.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Fixed

Made a quick scan of all the code, and it looked perfect.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Fixed » Needs review
Issue tags: -VDC

#1: 1765026.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +VDC

The last submitted patch, 1765026.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Just reading the patch. Whats the difference between "newDisplay" and "addDisplay". Are they named "correctly"?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

addDisplay adds a new viewDisplay.
newDisplay uses addDisplay and then automatically create a new display plugin instance, but i agree this is kind of confusing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Fixed

This is in, and a followup to fix an error too.

Automatically closed -- issue fixed for 2 weeks with no activity.