Similar to #1762352: clean up /camelCase methods on View we should cleanup the methods on the display

CommentFileSizeAuthor
#9 views-1762662-display-cc-9.patch243.57 KBdawehner
#7 views-1762662-7.patch244.24 KBtim.plunkett
#5 views-1762662-display-cc-5.patch243.65 KBdawehner
#2 views-1762662-display-cc.patch241.16 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +VDC
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
Issue tags: -VDC
FileSize
views-1762662-display-cc.patch241.16 KB

Wow this was way bigger then expected.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +VDC

.

Status: Needs review » Needs work

The last submitted patch, views-1762662-display-cc.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1762662-display-cc-5.patch243.65 KB

This should fix most of them.

You know, sometimes you regret when you start to work on something
because you really want to finish it.

Status: Needs review » Needs work

The last submitted patch, views-1762662-display-cc-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1762662-7.patch244.24 KB

Missed one in AreaTextTest.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work 
+++ b/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -78,7 +78,7 @@ abstract class FilterPluginBase extends HandlerBase {
+  function  init(&$view, &$options) {

Extra space between "function" and "init", and should be public.

+++ b/lib/Drupal/views/Plugin/views/style/Rss.phpundefined
@@ -32,7 +32,7 @@ class Rss extends StylePluginBase {
+  function attachTo($display_id, $path, $title) {

Should be public.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1762662-display-cc-9.patch243.57 KB 
+++ b/lib/Drupal/views/Plugin/views/filter/FilterPluginBase.phpundefined
@@ -78,7 +78,7 @@ abstract class FilterPluginBase extends HandlerBase {
+  function  init(&$view, &$options) {
Extra space between "function" and "init", and should be public.

+++ b/lib/Drupal/views/Plugin/views/style/Rss.phpundefined
@@ -32,7 +32,7 @@ class Rss extends StylePluginBase {
+  function attachTo($display_id, $path, $title) {
Should be public.

Removed both changes because they are out of scope of this issue.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Ok this is a huge patch...
I reviewed it (as good as possible) and this is good to go

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Title: cleanup methods on viewDisplay DisplayPluginBase » cleanup methods on DisplayPluginBase

Thank you for the review! I just have an idea for dreditor: Focus mode. Jump to the next change and hide the other ones, so you can quickly review patches like that.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

.

Automatically closed -- issue fixed for 2 weeks with no activity.