Just got distracted by that.

CommentFileSizeAuthor
#5 1760838-5.patch23.38 KBdamiankloip
#3 1760838-3.patch13.57 KBdamiankloip
api-version.patch10.69 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review

Do we have to change it in the config files too? Or does it happens automagicly?

Status: Needs review » Needs work

The last submitted patch, api-version.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs work » Needs review
FileSize
1760838-3.patch13.57 KB

Hopefully this patch applies. I have also added our default (config) views in here aswell.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

You can commit this but I would like to have a followup for

'api_version' and 'human_name' they are not consistent too.

2 vs 3 vs 3.0

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Reviewed & tested by the community » Needs review
FileSize
1760838-5.patch23.38 KB

Nah, I think it makes sense to get them all now :) two birds, one stone and all that .....

Just for clarity; this patch has all the core number changes, and the api_version changes :)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Perfect!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.