Document a lot of the function which generates the actual display options.

CommentFileSizeAuthor
#7 views-1760406-7.patch13.23 KBdawehner
#5 views-1760406-5.patch13.22 KBdawehner
#3 views-1760406-3.patch11.86 KBdawehner
#1 1760406-options-cleanup.patch11.66 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1760406-options-cleanup.patch11.66 KB

Things are getting a bit better.

Status: Needs review » Needs work

The last submitted patch, 1760406-options-cleanup.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1760406-3.patch11.86 KB

Just a small rerole of the patch and fixes the notices

Status: Needs review » Needs work

The last submitted patch, views-1760406-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1760406-5.patch13.22 KB

If you don't like me now, i'm angry with you testbot.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Needs work 
+++ b/lib/Views/node/Plugin/views/wizard/Node.phpundefined
@@ -191,7 +191,10 @@ class Node extends WizardPluginBase {
+  protected function page_display_options(array $form, array& $form_state) {

array& $form_state That works? Wow.

Also, you have keyed id a lot in comments, it should be keyed by ID.

Otherwise, looks good.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1760406-7.patch13.23 KB

I fixed array& $form_state to array &$form_state as well as the keyed id docs.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Woow looks great!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Thank you! Committed to 8.x and pushed.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Reviewed & tested by the community » Fixed

Automatically closed -- issue fixed for 2 weeks with no activity.