Another possible way to kill even more code

CommentFileSizeAuthor
#8 views-1758828-8.patch13.8 KBdawehner
#8 interdiff.txt753 bytesdawehner
#6 views-1758828-6.patch12.93 KBdawehner
#4 views-1758828-fix_missing_relationships.patch9.94 KBdawehner
#1 1758828-remove-relationships.patch8.67 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1758828-remove-relationships.patch8.67 KB 
git diff --stat                                                                                                                        ✭ ✱ 
 lib/Drupal/views/View.php  |   88 --------------------------------------------
 modules/comment.views.inc  |    9 -----
 modules/node.views.inc     |   15 --------
 modules/taxonomy.views.inc |   24 ------------
 modules/user.views.inc     |   48 ------------------------
 5 files changed, 184 deletions(-)

Status: Needs review » Needs work

The last submitted patch, 1758828-remove-relationships.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +VDC
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1758828-fix_missing_relationships.patch9.94 KB

Just a rerole of the patch and possible fixes of some of the tests.

Status: Needs review » Needs work

The last submitted patch, views-1758828-fix_missing_relationships.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
views-1758828-6.patch12.93 KB

Rerole the patch ...

Yes it makes sense to remove the test itself, as it tests basically exactly the fixMissingRelationship functionality.

Status: Needs review » Needs work

The last submitted patch, views-1758828-6.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
interdiff.txt753 bytes
views-1758828-8.patch13.8 KB

One of the default views had some relationships which got updated automatically before (but not on purpose)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Makes sense!

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

And go!

Automatically closed -- issue fixed for 2 weeks with no activity.