Once #1757302: Drupal\views\Plugin\views\query\Sql::execute() should stop silently catching Exceptions is in.

CommentFileSizeAuthor
#5 1758788.patch1.74 KBdawehner
#4 views-1757836-4.patch1.46 KBtim.plunkett
#2 drupal-1758788-2.patch9.21 KBtim.plunkett
#1 drupal-1758788-1.patch9.72 KBtim.plunkett
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Active » Needs review
FileSize
drupal-1758788-1.patch9.72 KB

I made some decisions here, so this needs more than technical review.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
drupal-1758788-2.patch9.21 KB

Rerolled with some suggestions from aspilicious and dawehner.
Will commit when green.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/d119a06

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Fixed » Needs review
FileSize
views-1757836-4.patch1.46 KB

Speaking of exceptions, these are named wrong.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
1758788.patch1.74 KB

Let's also use the actual Exception.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/647c1c0

Automatically closed -- issue fixed for 2 weeks with no activity.