There is a little more work on this, as in Views\taxonomy\Plugin\views\argument_validate\Term, for example, the terms are loaded directly from the db and not using entity_load etc..

CommentFileSizeAuthor
#19 1757050-views_entityload-19.patch5.23 KBACF
#17 1757050-views_entityload-16.patch4.8 KBACF
#15 1757050-views-renamefolder-14.patch9.63 KBACF
#13 1757050-views-renamefolder-12.patch14.09 KBACF
#10 1757050-views-renamefolder-10.patch13.46 KBACF
#8 1757050-views_entityload-8.patch4.19 KBACF
#6 1757050-views-entityloadfordb_select-5.patch4.53 KBACF
#5 1757050-views_entityload-5.patch21.88 KBACF
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Issue tags: +VDC
ACF’s picture

ACF CreditAttribution: ACF commented
Assigned: Unassigned » ACF
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

I saw damian started to work on that, but i'm not sure.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

I think that was term->name to term->label()

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1757050-views_entityload-5.patch21.88 KB

This is just the db_selects removed for entity loads

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1757050-views-entityloadfordb_select-5.patch4.53 KB

take 2 - with correct patch

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Active » Needs review
ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1757050-views_entityload-8.patch4.19 KB

This has the $term-tid replaced with $term->id() as well.

Status: Needs review » Needs work

The last submitted patch, 1757050-views_entityload-8.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
FileSize
1757050-views-renamefolder-10.patch13.46 KB

Renaming the folder to argument_validator

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review

Status: Needs review » Needs work

The last submitted patch, 1757050-views-renamefolder-10.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1757050-views-renamefolder-12.patch14.09 KB

try again

Status: Needs review » Needs work

The last submitted patch, 1757050-views-renamefolder-12.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1757050-views-renamefolder-14.patch9.63 KB

Status: Needs review » Needs work

The last submitted patch, 1757050-views-renamefolder-14.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1757050-views_entityload-16.patch4.8 KB

Please work.

Status: Needs review » Needs work

The last submitted patch, 1757050-views_entityload-16.patch, failed testing.

ACF’s picture

ACF CreditAttribution: ACF commented
Status: Needs work » Needs review
FileSize
1757050-views_entityload-19.patch5.23 KB

Another try.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Just fixed the indentation in the plugin annotation

Automatically closed -- issue fixed for 2 weeks with no activity.