Garland css and ie7 css should be removed.
And cleanup the other css if needed.

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

Issue tags: +VDC

.

slv_’s picture

Status: Active » Needs review
FileSize
8.29 KB

Patch attached for this. Did some string search on the other css files but didn't found anything <= IE7-specific.

aspilicious’s picture

Status: Needs review » Needs work

Somewhere in code these files will be called :). Those lines have to be removed.

dawehner’s picture

Status: Needs work » Needs review

What about that then?

aspilicious’s picture

Status: Needs review » Needs work

I mean this line for example in includes/admin.inc

$list[$module_path . '/css/ie/views-admin.ie7.css'] = array(

slv_’s picture

FileSize
9.41 KB

Just fixed that as well. Also removed garland from the list of themes being checked.

Patch attached

aspilicious’s picture

Status: Needs work » Needs review
dawehner’s picture

Status: Needs review » Reviewed & tested by the community

Ups i had added a patch anyway this looks fine for me.

dawehner’s picture

Status: Reviewed & tested by the community » Fixed

Awesome, committed to 8.x-3.x

dead_arm’s picture

Assigned: Unassigned » dead_arm
Status: Fixed » Active

I'm going to work on some of the non-IE sheets.

dead_arm’s picture

Status: Active » Needs review
FileSize
1.03 KB

See attached patch. Remove padding, use consistent values, remove duplication of label weight, and remove unneeded border override.

dead_arm’s picture

FileSize
9.97 KB

See attached patch. Removing the advanced help CSS sheet, using the module.base.css naming standard [#1089868], removing vendor prefixing of border-radius #1422614: Drop Firefox 3.6 support in Drupal core and removed units on 0.

aspilicious’s picture

-  border-radius: 5px 5px 0 0;
+  border-radius: 5px 0;

I think that isn't the same.

Admin css should end with admin.css, that way we can write code to remove those css files if needed.
So I suggest:

views.admin.css
views.admin-rtl.css
views.bartik.admin.css OR views-bartik.admin.css
views.bartik.admin-rtl.css OR views-bartik.admin-rtl.css
...

That way rtl css files also get called automagicly. Ihave no clue how that is working now in views.

dead_arm’s picture

FileSize
9.9 KB

Attached patch to put border-radius: 5px 5px 0 0; back.

aspilicious’s picture

Looks good now, leave the final judgement to someone else

dead_arm’s picture

FileSize
11.29 KB

Uploading as a multi-commit patch.

Status: Needs review » Needs work

The last submitted patch, views-1754316-16.patch, failed testing.

tim.plunkett’s picture

Status: Needs work » Fixed

Committed, left the Advanced Help file to be removed in #1757234: Remove advanced help integration.

Automatically closed -- issue fixed for 2 weeks with no activity.