Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Garland css and ie7 css should be removed.
And cleanup the other css if needed.
Comment | File | Size | Author |
---|---|---|---|
#16 | views-1754316-16.patch | 11.29 KB | dead_arm |
#14 | views-1754316-14.patch | 9.9 KB | dead_arm |
#12 | views-1754316-12.patch | 9.97 KB | dead_arm |
#11 | views-1754316-11.patch | 1.03 KB | dead_arm |
#6 | 1754316-css_cleanup-6.patch | 9.41 KB | slv_ |
Comments
Comment #1
dawehner.
Comment #2
slv_ CreditAttribution: slv_ commentedPatch attached for this. Did some string search on the other css files but didn't found anything <= IE7-specific.
Comment #3
aspilicious CreditAttribution: aspilicious commentedSomewhere in code these files will be called :). Those lines have to be removed.
Comment #4
dawehnerWhat about that then?
Comment #5
aspilicious CreditAttribution: aspilicious commentedI mean this line for example in includes/admin.inc
$list[$module_path . '/css/ie/views-admin.ie7.css'] = array(
Comment #6
slv_ CreditAttribution: slv_ commentedJust fixed that as well. Also removed garland from the list of themes being checked.
Patch attached
Comment #7
aspilicious CreditAttribution: aspilicious commentedComment #8
dawehnerUps i had added a patch anyway this looks fine for me.
Comment #9
dawehnerAwesome, committed to 8.x-3.x
Comment #10
dead_armI'm going to work on some of the non-IE sheets.
Comment #11
dead_armSee attached patch. Remove padding, use consistent values, remove duplication of label weight, and remove unneeded border override.
Comment #12
dead_armSee attached patch. Removing the advanced help CSS sheet, using the module.base.css naming standard [#1089868], removing vendor prefixing of border-radius #1422614: Drop Firefox 3.6 support in Drupal core and removed units on 0.
Comment #13
aspilicious CreditAttribution: aspilicious commentedI think that isn't the same.
Admin css should end with admin.css, that way we can write code to remove those css files if needed.
So I suggest:
views.admin.css
views.admin-rtl.css
views.bartik.admin.css OR views-bartik.admin.css
views.bartik.admin-rtl.css OR views-bartik.admin-rtl.css
...
That way rtl css files also get called automagicly. Ihave no clue how that is working now in views.
Comment #14
dead_armAttached patch to put border-radius: 5px 5px 0 0; back.
Comment #15
aspilicious CreditAttribution: aspilicious commentedLooks good now, leave the final judgement to someone else
Comment #16
dead_armUploading as a multi-commit patch.
Comment #18
tim.plunkettCommitted, left the Advanced Help file to be removed in #1757234: Remove advanced help integration.