#1754216: Meta: Add one test that tests each plugin type intensive

CommentFileSizeAuthor
#3 interdiff.txt1.16 KBdawehner
#3 views-1754232-3.patch3.94 KBdawehner
#1 views-1754232-1.patch3.55 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
views-1754232-1.patch3.55 KB

Here is a patch for that.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented 
+++ b/lib/Drupal/views/Tests/Plugin/ArgumentDefaultTest.phpundefined
@@ -43,6 +46,39 @@ class ArgumentDefaultTest extends PluginTestBase {
+    $expected_result = array();
+    $expected_result[] = array('name' => 'John');

I think we can merge this into 1 line.
Don't we need to verify the default is not used when we provide an argument?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
views-1754232-3.patch3.94 KB
interdiff.txt1.16 KB

I totally agree, here is an update.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Looks great now :)

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

Thank you! Committed and pushed.

Automatically closed -- issue fixed for 2 weeks with no activity.