The CHANGELOG.txt should be updated with a few more new features and changes.

I read through the Converting 5.x modules to 6.x page and tried to pull out some highlights that I didn't see in the latest version of the CHANGELOG.txt

- Upgraded the jQuery javaScript library to version 1.2
- All event-triggered, javascript behaviors can now be registered in the Drupal.behaviors object
- Major improvements to the consistency and reliability of the FormAPI
- Database table creation for modules has now been abstracted into a new Schema API
- New function to determine whether a certain database table column exists that's independent of the database
- Removal of various database-dependent functions and arguments
- Variable names can now be 128 characters long
- Expose Drupal data structures for manipulation by other modules with the new drupal_alter() function
- Ability to do dynamic theming with wildcards
- The .info file now specifies which Drupal core version a module or theme has been ported to
- Can now specify the minimum PHP version required for module within the .info file 
- Cache set and get automatically (un)serialize complex data types
- New function to scale an image to an exact height and width
- It's now easier to preview uploaded files and to create and remove temporary files during a cron job
- Changes to the Distributed Authentication system for integrating external authentication services into Drupal.
- Modules can now execute code at the beginning of a page request for both cached and non-cached pages.
- Node access permission grants are now automatically rebuilt when modules are enabled or disabled if needed

<strong>CHANGE</strong> "Added support for configurable actions." <strong>TO</strong> "Added support for triggering configurable actions."

Please suggest any changes or things to remove.

CommentFileSizeAuthor
#10 drupal-changelog-6-beta-175197-10.patch6.62 KBwebchick
#8 changelog_update_6beta_1.patch2.78 KBKentBye
#4 changelog_update_6beta_0.patch2.9 KBKentBye
#1 changelog_update_6beta.patch3.68 KBKentBye
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

KentBye’s picture

KentBye CreditAttribution: KentBye commented
Status: Active » Needs review
FileSize
changelog_update_6beta.patch3.68 KB

Here's a patch that changes the verb tense of the previous list.

I excluded a few items -- like node access permission and extended variable length -- and there may be other things that need to be added to it or not included at all.

keith.smith’s picture

keith.smith CreditAttribution: keith.smith commented
Status: Needs review » Needs work

All in all, I like these additions, though I know that many improvements were purposefully not mentioned in the CHANGELOG.txt. Beyond any larger argument about what should or should not be included, though, I noticed a very few small nitpicks with the patch:

  • previously, entries seemed to always end with a '.' . Entries added by this patch do not -- or at least, most that I noticed do not.
  • I noticed instances of "Javascript", "javaScript", and "javascript" (varying capitalization)
  • section headers only have a single starting capital, unlike the added "Database Abstraction" header (and possibly others)
  • I admit to not quite understanding what "New function to determine whether a certain database table column exists that's independent of the database" means. Existentially, I guess we could debate whether a column CAN exist independent of a database. :) Maybe it means that the existence of a column can be determined independently of whether the underlying database is MySQL, or PostgreSQL, etc. If that is the case, perhaps the very next entry regarding database-dependent functions can be expanded instead.
jrabeemer’s picture

jrabeemer CreditAttribution: jrabeemer commented

This is too terse and detailed. You need to focus on the big picture "bird's eye" features. The minutia is killing me. Also, please fix your patch set.

http://drupal.org/patch/create

KentBye’s picture

KentBye CreditAttribution: KentBye commented
Status: Needs work » Needs review
FileSize
changelog_update_6beta_0.patch2.9 KB

Thanks for the feedback.

I removed a lot of the original additions and cleaned up some of the other suggestions as detailed below.
Please be specific for anything else to remove or add back in.

Additions

* Can now specify the minimum PHP version required for a module within the .info file.
* Added ability for dynamic theming with wildcards.
* Added ability to create and remove temporary files during a cron job.
- Upgraded the core JavaScript library to jQuery version 1.2.
- Added hooks that allow modules to execute code at the beginning of a page request for either cached or non-cached pages.
- Added a new Schema API that abstracts the process of creating new database tables.

Changed wording of 

- Added support for triggering configurable actions.
- Added versioning support to taxonomy terms by associating them with node revisions.

Additions removed from the original list

- Improved the consistency and reliability of the FormAPI
- Added a hook that allows other modules to manipulate Drupal data strutures
- Changed the distributed authentication system for integrating external authentication services into Drupal
* New function to determine whether a certain database table column exists that's independent of the database
* Removal of various database-dependent functions and arguments.
- Changed cache set and cache get to automatically (un)serialize complex data types
- Node access permission grants are now automatically rebuilt when modules are enabled or disabled if needed
- Extended the length of variable names to be up to 128 characters long
- Improved preview of uploaded files 
- Added new function to scale images to an exact height and width.
KentBye’s picture

KentBye CreditAttribution: KentBye commented

Ooops. I meant additions removed from the previous patch -- not the original list.
Just wanted to be clear that I didn't remove anything from the changelog.txt

chx’s picture

chx CreditAttribution: chx commented

Added hooks that allow modules to execute code at the beginning of a page request for either cached or non-cached pages.

despite this is my work, this has nothing to do in changelog

chx’s picture

chx CreditAttribution: chx commented

Also, about terms... "Categories are now associated with node revisions not the node itself".

KentBye’s picture

KentBye CreditAttribution: KentBye commented
FileSize
changelog_update_6beta_1.patch2.78 KB

Thanks chx.

Here's a new patch.

Removed
"Added hooks that allow modules to execute code at the beginning of a page request for either cached or non-cached pages."

Changed "taxonomy terms" to "categories"
"Added versioning support to categories by associating them with node revisions."

Let me know if there's anything else that should be removed, added or changed.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Title: Update CHANGELOG.txt for Drupal 6 » Beta-breaker: Update CHANGELOG.txt for Drupal 6
Status: Needs review » Needs work

Thanks a lot, Kent! This is looking *just* about ready:

+ * Added ability for dynamic theming with wildcards.

I have no idea what that means. No, seriously. I have no idea what that means. :)

+- Added a new Schema API that abstracts the process of creating new database tables.

How about we re-phrase this in a way that's more end-user focused, like:

+- Added a new Schema API that provides built-in support for all core and contributed modules for databases other than MySQL.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Needs work » Needs review
FileSize
drupal-changelog-6-beta-175197-10.patch6.62 KB

Ok, this patch is slightly bigger as it shortens the lines to 80 chars, per the coding standards.

I removed both the "wildcard" thing and also the entry about user profiles using array rendering or something like that. TMI.

I reworded the Schema API entry to:

+- Added a new Schema API, which provides built-in support for core and
+  contributed modules to work with databases other than MySQL.

Ready for another round of reviews.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Priority: Normal » Critical

Bumping this to critical -- we should have a complete CHANGELOG.txt before shipping a beta.

KentBye’s picture

KentBye CreditAttribution: KentBye commented

The code clean-up looks great webchick, and I agree with axing the theming wildcard entry.

I guess the target audience is lay people installing Drupal, and not necessarily Drupal developers.

And unless anyone else has any other suggestions for removing, adding or changing anything, then I think this is ready to go in.
But I'll give it some more time for any other feedback before marking it RTBC.

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

I guess this one is good to go.

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks. I am glad the final patch did not include such "subtle" changes, like the variable name length or database function changes. They were definitely not CHANGELOG-worthy. Committed.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)