If you look at DisplayPluginBase::init() you will see some code
which tries to handles old configuration.

Before drupal8 we should clean them up so we don't have to handle with that old piece of code.

CommentFileSizeAuthor
#16 views-1748118-16.patch18.68 KBtim.plunkett
#14 interdiff.txt969 bytesdawehner
#14 1748118-init-update-14.patch18.57 KBdawehner
#11 1748118-init-update-11.patch16.23 KBdawehner
#7 views-init-1748118-7.patch22.82 KBtim.plunkett
#5 1748118-clear-init-methods-5.patch29.62 KBdawehner
#5 interdiff.txt603 bytesdawehner
#3 interdiff.txt16.72 KBdawehner
#3 1748118-clear-init-methods-3.patch29.28 KBdawehner
#1 1748118-clear-init-methods.patch14.67 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1748118-clear-init-methods.patch14.67 KB

Here is a first patch which seems to remove all what is left.

Status: Needs review » Needs work

The last submitted patch, 1748118-clear-init-methods.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
1748118-clear-init-methods-3.patch29.28 KB
interdiff.txt16.72 KB

There were multiple problems:

  • There were update specific tests
  • There were non updated tests
  • There was some code removed by accident.

Status: Needs review » Needs work

The last submitted patch, 1748118-clear-init-methods-3.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
interdiff.txt603 bytes
1748118-clear-init-methods-5.patch29.62 KB

And a bug in the test.

Status: Needs review » Needs work

The last submitted patch, 1748118-clear-init-methods-5.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-init-1748118-7.patch22.82 KB

Trying without the changes to DisplayTestCase, see #1754270: DisplayTestCase has two test cases that call the same view and ignore the other

Status: Needs review » Needs work

The last submitted patch, views-init-1748118-7.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented 
/ If any of the displays use jump menus, we want to add fields to the view
+    // that store the path that will be used in the jump menu. The fields to

Jump menus are moved to ctools? If thats the case can't we move this to ctools too?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Well this already got moved, the patch sadly is against the wrong version, because there was no reroll yet.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
1748118-init-update-11.patch16.23 KB

Posted a recent version of the patch without the test changes as tim mentioned.

Status: Needs review » Needs work

The last submitted patch, 1748118-init-update-11.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

Filter group thingies need to be changed

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
1748118-init-update-14.patch18.57 KB
interdiff.txt969 bytes

Some more cleanup but i still don't have a clue, why the filter tests don't work.

Status: Needs review » Needs work

The last submitted patch, 1748118-init-update-14.patch, failed testing.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Needs review
FileSize
views-1748118-16.patch18.68 KB

I tested just the Numeric one locally, and fixed it. I think it might help the others as well?

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented 
     if (!empty($options['exposed']) && !empty($options['expose']['operator']) && !isset($options['expose']['operator_id'])) {
-      $this->options['expose']['operator_id'] = $options['expose']['operator_id'] = $options['expose']['operator'];
+      $this->options['expose']['operator_id'] = $options['expose']['operator'];

&& !isset($options['expose']['operator_id']

still needed?

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/7f86935

Automatically closed -- issue fixed for 2 weeks with no activity.