Notices when editing comments & related comment moderation bug [#174233]

Comment	File	Size	Author
#4	comment_notices_0.patch	3.34 KB	webernet

#3	comment_notices.patch	3.27 KB	webernet

#1	comment.module_81.patch	78.55 KB	julien

Comment #1

julien CreditAttribution: julien commented 10 September 2007 at 05:05

File	Size
comment.module_81.patch	78.55 KB

Hi,

I have reproduce this issue, and i have seen by a var_dump of $edit that two fields were missing in this array : $edit['mail'] and $edit['homepage'].
i have add a line before the query to add this two fields who are called by the sql query the next line.
To fix the second notice with $status, i check if the $status is set or not.

For $edit['mail'], i think we can set it up by a sql query who will get the email of this user by his uid. For the homepage, i don't know there is no field in the user table for it.

Hope this will help.

Log in or register to post comments

Comment #2

fwalch CreditAttribution: fwalch commented 10 September 2007 at 17:23

You should create a patch instead of uploading the whole file. Read this handbook page to learn how to create patches for Drupal.

Log in or register to post comments

Comment #3

webernet CreditAttribution: webernet commented 27 September 2007 at 16:13

Status:

Active

» Needs review

File	Size
comment_notices.patch	3.27 KB

Attached patch fixes the notices, as well as a code style (indenting) issue.

It also fixes what appears to be a bug: comments that have been approved are not returned to the moderation queue after being edited by a user without 'post comments without approval' permission.

Log in or register to post comments

Comment #4

webernet CreditAttribution: webernet commented 27 September 2007 at 16:49

File	Size
comment_notices_0.patch	3.34 KB

Slightly faster and cleaner.

Log in or register to post comments

Comment #5

Freso CreditAttribution: Freso commented 28 September 2007 at 07:42

Status:

Needs review

» Needs work

It also fixes what appears to be a bug: comments that have been approved are not returned to the moderation queue after being edited by a user without 'post comments without approval' permission.

As much as I agree that this is a bug (even a possibly related one) and should be fixed ASAP, I'm still leaning towards having it filed as a separate issue with a separate patch. ("One fix per patch.")

Log in or register to post comments

Comment #6

webernet CreditAttribution: webernet commented 28 September 2007 at 11:20

Title:	Notices when editing comments	» Notices when editing comments & related comment moderation bug
Status:	Needs work	» Needs review

One of the notices is due to the missing status field in a query, therefore fixing it requires setting the status and, as a direct consequence, fixing the related bug.

Log in or register to post comments

Comment #7

Freso CreditAttribution: Freso commented 28 September 2007 at 12:44

Alright then.

I can reproduce the bug. Applying the patch (which happens cleanly) fixes it as advertised. I didn't test the moderation bug, thus not marking RTBC.

Log in or register to post comments

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 28 September 2007 at 15:40

Looks good, so once both bugs are tested against, I think this is ready to go.

Log in or register to post comments

Comment #9

Freso CreditAttribution: Freso commented 28 September 2007 at 17:08

Status:

Needs review

» Reviewed & tested by the community

I added a new user to the install, that only had permissions to access and post comments without approval. Before the patch, the user got notices after editing comments, and the already-approved comments were directly re-approved. After the patch, the notices are gone and the comment is put back into moderation. All in all, the patch works as advertised. :)

Marking RTBC per Gábor's comment.