Remove db_update_field [#173566]

The db_update_field() function never should have been committed; it was my mistake to include it in the patch. It is very dangerous to have around because contrib authors will use it incorrectly (e.g. in a hook_update_N() function).

Core does not use it. Currently the only legitimate use for it is modules like CCK that dynamically modify tables but "like CCK" means "only CCK" and the function should just be part of CCK in D6.

Comment	File	Size	Author
#1	db-update-field-173566-1.patch	2.59 KB	bjaspan
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

bjaspan CreditAttribution: bjaspan commented 6 September 2007 at 17:23

Status:

Active

» Needs review

File	Size
db-update-field-173566-1.patch	2.59 KB

Patch attached.

Comment #2

bjaspan CreditAttribution: bjaspan commented 6 September 2007 at 17:25

I'll add that I marked this 'critical' because if we do not remove the function, contrib authors will use it incorrectly resulting in a situation that will be very difficult or impossible to recover from smoothly. Users will end up having to uninstall modules (drop tables) and reinstall to recover, losing data in the process. We really want to avoid that.