Is this concatenation necessary: '/\\\\(.)' .'/' ?
To me a simpler way to write it is '/\\\\(.)/'
Am I missing something?

CommentFileSizeAuthor
common.inc_concat.patch832 bytesscor
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

kkaefer’s picture

kkaefer CreditAttribution: kkaefer commented

That string split-up shouldn't be necessary. I have no idea why it is in there. It may result from the packer code we copied from somewhere.

Freso’s picture

Freso CreditAttribution: Freso commented

The patch looks good to me. I must admit, though, that I'm not entirely sure what I'd need to do to test this, so I'm wary of marking RTBC, even if my gut feeling says it should be able to go straight in.

Steven Jones’s picture

Steven Jones CreditAttribution: Steven Jones commented
Status: Needs review » Reviewed & tested by the community

Looks good (packer still works after the patch is applied)

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Reviewed & tested by the community » Fixed

Thanks, committed.

scor’s picture

scor CreditAttribution: scor commented

fyi, according to Steven, these were leftover code from porting js code to php.

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)