see patch

CommentFileSizeAuthor
ip_0.patch952 byteskilles@www.drop.org
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Dries’s picture

Dries CreditAttribution: Dries commented

I'd suggest that we simply write 'ip' => ip_address().

Dries’s picture

Dries CreditAttribution: Dries commented
Status: Needs review » Fixed

Committed to CVS HEAD. Thanks.

killes@www.drop.org’s picture

killes@www.drop.org CreditAttribution: killes@www.drop.org commented
Priority: Normal » Critical
Status: Fixed » Needs review

Dries omitted part of the patch...

Gábor Hojtsy’s picture

Gábor Hojtsy
he/him
Primary language Hungarian
Location Hungary
CreditAttribution: Gábor Hojtsy commented
Status: Needs review » Fixed

Indeed, Dries did not notice that ip was used twice. Well, I did not notice it either, without closer inspection. So committed a fix to go to the original patch, which makes better reuse of the ip_address() output. Thanks for the note!

Anonymous’s picture

(not verified) CreditAttribution: commented
Status: Fixed » Closed (fixed)