API page: http://api.drupal.org/api/drupal/core%21modules%21entity%21lib%21Drupal%...

In the $langcode description, change "getting" to "setting". Afterwards, it will read, "...the language that should be used for setting the property."

Also, is an example of the $value parameter appropriate, such as that in http://drupal.org/node/1532946?

CommentFileSizeAuthor
#8 string-change-1729986-8.patch836 byteskid_icarus
#6 string-change-1729986-6.patch758 bytesdermario
#4 string-change-1729986-4.patch627 bytesmd2
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

salah1’s picture

salah1
Location VA, U.S
CreditAttribution: salah1 commented
Assigned: Unassigned » salah1

I saw that. I will work on correcting this.
Thanks

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Issue tags: +Novice

Looks like a little copy/paste error -- good catch!

m-abshir: are you still working on this? If not, please un-assign, and if there is no response in the next week someone else can also assign to themselves and take it over. Thanks!

salah1’s picture

salah1
Location VA, U.S
CreditAttribution: salah1 commented
Assigned: salah1 » Unassigned
md2’s picture

md2 CreditAttribution: md2 commented
Status: Active » Needs review
FileSize
string-change-1729986-4.patch627 bytes

Patch for string change.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

This patch not correct. It is incorrectly changing the text of the label() method, which is documented to get the label, not the set() method, which is used for setting properties.

dermario’s picture

dermario
Primary language German
Location Zürich
CreditAttribution: dermario commented
Status: Needs work » Needs review
FileSize
string-change-1729986-6.patch758 bytes

Let me give a try. This is my first patch.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Needs review » Needs work

I cannot get this patch to apply right now... maybe it needs a reroll?

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs review » Needs work
FileSize
string-change-1729986-8.patch836 bytes

So it looks like #1668820: Concept, base class, and interface for Configurables (e.g., node types, image styles, vocabularies, views, etc) got in the way of this one. Re-rolled, applies cleanly at a76f10d. Please also note that this patch varies slightly in order to abide by the 80 character limit.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review

whoops :-P

Status: Needs review » Needs work
Issue tags: -Novice

The last submitted patch, string-change-1729986-8.patch, failed testing.

kid_icarus’s picture

kid_icarus CreditAttribution: kid_icarus commented
Status: Needs work » Needs review
Issue tags: +Novice

#8: string-change-1729986-8.patch queued for re-testing.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Title: Change "getting" to "setting" in EntityInterface::set » Change "getting" to "setting" in StorableInterface::set
Status: Needs work » Fixed

Thanks! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.