Batch engine breaks with drupal_execute [#172824]

Reported by chx : when drupal_execute is used inside a batched function call, the batch processing breaks completely.
(when processing the programmatic form, FAPI checks if batches were set in form handlers, but in fact catches the batch
being currently processed and attempts to re-process it).

Simple fix attached.

Comment	File	Size	Author
#4	batch_drupal_execute_example.patch	1.6 KB	yched
#4
	batch_drupal_execute.patch	903 bytes	yched

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 7 September 2007 at 12:31

what is easiest way to test this?

Comment #2

chx CreditAttribution: chx commented 7 September 2007 at 12:36

The issue revealed itself when i tried to drupal_execute the menu edit menu form in an upgrade -- the upgrade froze. Try doing a multipart upgrade and drupal_execute inside

Comment #3

yched CreditAttribution: yched commented 7 September 2007 at 16:17

Actually, there should be no need to set up a multi-step upgrade.
just add a dummy system_update_n that simply drupal_executes a stupid form ('OK' button, drupal_set_message('foobar') in the form submit handler).

I'm away from home these days, and can't easily wrap up sample code, unfortunately.

Comment #4

yched CreditAttribution: yched commented 8 September 2007 at 11:50

File	Size
batch_drupal_execute_example.patch	1.6 KB

OK, here is an *example* (not for actual core inclusion :-) ) patch for system.module, that adds dummy updates to illustrate the bug.
The actual patch to review / commit is in the original post.