Currently you have something like

The plugin did not specify an instance class.

but the message could be improved by specify the actual plugin_id so you automatically know where to look for.

CommentFileSizeAuthor
#1 1726794-factory-message.patch1.03 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1726794-factory-message.patch1.03 KB

Here is a small patch for that.

Status: Needs review » Needs work

The last submitted patch, 1726794-factory-message.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review

#1: 1726794-factory-message.patch queued for re-testing.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
CreditAttribution: amitaibu commented

Maybe better use format_string() instead of sprtintf()?

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Well the problem is that these files are part of the component so they should be decoupled from the actual drupal system.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Oh god please yes, this is so anoying :)

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Reviewed & tested by the community » Needs review
Issue tags: +Plugin system

adding tag, I'm ++ on this in general, I will try to get someone who's using it to rtbc it shortly.

Eclipse

EclipseGc’s picture

EclipseGc CreditAttribution: EclipseGc commented
Status: Needs review » Reviewed & tested by the community

cross post, sorry.

webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Category: feature » task
Status: Reviewed & tested by the community » Fixed

Good catch. I actually see this as more of a task than a feature request, because the exception message as-is is not helpful.

Committed and pushed to 8.x. Thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.