Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
PHP Filter module's current help page at admin/help/php contains just:
"Adds a filter option to include PHP in content."
We need a fully-blown help page here, like admin/help/aggregator: one sentence description, paragraph of more detailed description.
Comment | File | Size | Author |
---|---|---|---|
#18 | 172583-18.patch | 1.7 KB | keith.smith |
#16 | 172583-16.patch | 1.7 KB | keith.smith |
#14 | 172583-14.patch | 1.64 KB | keith.smith |
#13 | 172583-13.patch | 1.64 KB | keith.smith |
#9 | 172583-9.patch | 1.68 KB | keith.smith |
Comments
Comment #1
gregglesLooking at the regular "Filter" module help from D6 and at the "Filter module" help from D5, I don't think we need a whole lot here. I think it would be sufficient to simply link to the Filter module help and then say that this module evaluates php code.
What about just using the text that gets added to the filter tips?
Comment #2
webchickno, we definitely need more than that. We should talk about the security implications of this module, for one thing.
Comment #3
bradlis7 CreditAttribution: bradlis7 commentedHere's a starting point, but you don't have to use it:
Comment #4
Gábor HojtsyLet's explain what is PHP all about. This is a user facing module after all. Also don't use "node" in user facing help, user "post" or "content".
Comment #5
alpritt CreditAttribution: alpritt commentedPatch is mostly from comment #4, but with some grammar changes.
Comment #6
bradlis7 CreditAttribution: bradlis7 commentedShould we list the api.drupal.org, and the PHP documentation page?
Comment #7
bradlis7 CreditAttribution: bradlis7 commentedThere is also some information in the filter/tips page, in which you have permission for the PHP Filter.
Comment #8
keith.smith CreditAttribution: keith.smith commentedI haven't put this in patch form yet, but I easily can (and will). What about something like the following, which builds off of the last several suggestions.
Comment #9
keith.smith CreditAttribution: keith.smith commentedAnd the patch with the text from above.
Comment #10
dmitrig01 CreditAttribution: dmitrig01 commentedthe content management system used by this website has been developed using PHP code.
Maybe
Drupal is written in PHP
Comment #11
gregglesTo the extent we want to make it easy to enable profiles built on Drupal it's better to say "content management system" or just "system" instead of "Drupal".
Comment #12
ChrisKennedy CreditAttribution: ChrisKennedy commentedYou might change "Drupal programming knowledge" to "knowledge of the Drupal API." or "knowledge of the Drupal CMS." or "knowledge of the Drupal framework." The current version implies that Drupal is a programming language, when it is really an API/framework.
Also, "granted permissions" should be "granted permission".
Comment #13
keith.smith CreditAttribution: keith.smith commentedNew patch attached incorporating the suggestions from ChrisKennedy's comments in #12.
Comment #14
keith.smith CreditAttribution: keith.smith commentedOr rather, this one is.
On closer inspection, there were actually two instances of "permissions" that needed to be "permission" in the text; this patch adjusts both of them.
Comment #15
Freso CreditAttribution: Freso commentedShouldn't "Drupal.org" link to, say, drupal.org?
Comment #16
keith.smith CreditAttribution: keith.smith commentedAbsolutely it should. Or surely it can. Or something like that.
New patch attached adding Drupal.org as a link.
Comment #17
ChrisKennedy CreditAttribution: ChrisKennedy commentedThe last minor thing is that in "all PHP code added through the Filter" it looks weird to have filter capitalized. IMO it should either be lowercase or the full "PHP Filter".
Comment #18
keith.smith CreditAttribution: keith.smith commentedGood point. Patch updated, and now refers to "PHP Filter" in place of just "Filter".
Thanks for reviewing.
Comment #19
Gábor HojtsyCommitted the latest patch with some modifications:
- "PHP Filter" should actually be "PHP filter". Drupal is more towards European conventions in which we don't capitalize est paragraph and say Drupal outright.
- Drupal CMS modified to Drupal system (it should have been Drupal API, but I tried to not use technical terms
Thanks for everybody involved.
Comment #20
(not verified) CreditAttribution: commentedAutomatically closed -- issue fixed for two weeks with no activity.