On the confirm form:

    * notice: Trying to get property of non-object in /Users/webchick/Sites/head/modules/user/user.module on line 2026.
    * notice: Undefined index: in /Users/webchick/Sites/head/modules/user/user.module on line 2026.
    * notice: Trying to get property of non-object in /Users/webchick/Sites/head/modules/user/user.module on line 2026.
    * warning: htmlspecialchars() expects parameter 1 to be string, array given in /Users/webchick/Sites/head/includes/bootstrap.inc on line 669.

After deleting:

    * notice: Trying to get property of non-object in /Users/webchick/Sites/head/modules/user/user.module on line 2026.
    * notice: Undefined index: in /Users/webchick/Sites/head/modules/user/user.module on line 2026.
    * notice: Trying to get property of non-object in /Users/webchick/Sites/head/modules/user/user.module on line 2026.

Deletion of the rule fails.

CommentFileSizeAuthor
#2 access_confirm_0.patch1.51 KBchx
#1 access_confirm.patch1.15 KBchx
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

chx’s picture

Status: Active » Needs review
FileSize
1.15 KB

I fixed a notice on create too which revaled a serious problem, actually.

chx’s picture

Title: Can't delete access rules » User module Drupal 6 conversion incomplete
FileSize
1.51 KB

I really do not want to file a separate issue for this but there is another missing form_state in user module. As far as I can tell, there are no other missing form_states in Drupal core, I have written a little scripts which iterates menu for drupal_get_forms and also checks the explicit drupal_get_form calls. Of course, there might be some problems, it's a simple script but I think we are covered.

snufkin’s picture

Status: Needs review » Reviewed & tested by the community

the issue is confirmed, together with create notice chx mentioned.

the patch works, tested with editing, adding, deleting and checking rules, solves both issues.

Gábor Hojtsy’s picture

Status: Reviewed & tested by the community » Fixed

Thanks, committed!

Anonymous’s picture

Status: Fixed » Closed (fixed)