Javascript breaks when Javascript aggregation is enabled [#172149]

Comment	File	Size	Author
#2	add_js_semicolon_1.patch	1.64 KB	dvessel

Comment #1

dvessel CreditAttribution: dvessel commented 31 August 2007 at 17:25

I can verify this problem. It also happens in example.com/admin/user/user which loads these to scripts when not aggregated.

<script type="text/javascript" src="/misc/jquery.js"></script>
<script type="text/javascript" src="/misc/drupal.js"></script>
<script type="text/javascript" src="/misc/tableselect.js"></script>
<script type="text/javascript" src="/misc/tableheader.js"></script>

Gives a parsing error.

Log in or register to post comments

Comment #2

dvessel CreditAttribution: dvessel commented 31 August 2007 at 18:23

Status:

Active

» Needs work

File	Size
add_js_semicolon_1.patch	1.64 KB

It was a missing semicolon at the end of the function. Deans packer script requires it. I found only 3 instances of this.

Log in or register to post comments

Comment #3

dvessel CreditAttribution: dvessel commented 31 August 2007 at 18:24

Status:

Needs work

» Needs review

Log in or register to post comments

Comment #4

pwolanin CreditAttribution: pwolanin commented 31 August 2007 at 18:25

Title:

Javascript breaks when both Book module and Javascript aggregation are enabled

» Javascript breaks when Javascript aggregation is enabled

Log in or register to post comments

Comment #5

pwolanin CreditAttribution: pwolanin commented 31 August 2007 at 18:35

added a new page to the Handbook under coding standards:

http://drupal.org/node/172169

Log in or register to post comments

Comment #6

webernet CreditAttribution: webernet commented 31 August 2007 at 18:43

Status:

Needs review

» Reviewed & tested by the community

Tested OK.

Log in or register to post comments

Comment #7

pwolanin CreditAttribution: pwolanin commented 31 August 2007 at 18:49

I also tested, and this fixes the bugs.

Log in or register to post comments

Comment #8

Gábor Hojtsy

he/him

Hungarian

Hungary

CreditAttribution: Gábor Hojtsy commented 1 September 2007 at 07:08

Status:

Reviewed & tested by the community

» Fixed

This sounds quite logical, committed.

Log in or register to post comments

Comment #9

dvessel CreditAttribution: dvessel commented 1 September 2007 at 16:34

Wanted to note that webernet found the bug and pretty much found the cause, we were all searching for where it was happening and after it was found, I made the patch. So, he should be credited too.