Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 UTC on 18 March 2024, to get $100 off your ticket.
Javascript is broken when both the book.module and the javascript aggregation performance setting are enabled.
Comment | File | Size | Author |
---|---|---|---|
#2 | add_js_semicolon_1.patch | 1.64 KB | dvessel |
Comments
Comment #1
dvessel CreditAttribution: dvessel commentedI can verify this problem. It also happens in example.com/admin/user/user which loads these to scripts when not aggregated.
Gives a parsing error.
Comment #2
dvessel CreditAttribution: dvessel commentedIt was a missing semicolon at the end of the function. Deans packer script requires it. I found only 3 instances of this.
Comment #3
dvessel CreditAttribution: dvessel commentedComment #4
pwolanin CreditAttribution: pwolanin commentedComment #5
pwolanin CreditAttribution: pwolanin commentedadded a new page to the Handbook under coding standards:
http://drupal.org/node/172169
Comment #6
webernet CreditAttribution: webernet commentedTested OK.
Comment #7
pwolanin CreditAttribution: pwolanin commentedI also tested, and this fixes the bugs.
Comment #8
Gábor HojtsyThis sounds quite logical, committed.
Comment #9
dvessel CreditAttribution: dvessel commentedWanted to note that webernet found the bug and pretty much found the cause, we were all searching for where it was happening and after it was found, I made the patch. So, he should be credited too.
Comment #10
(not verified) CreditAttribution: commented