here you go

CommentFileSizeAuthor
fix_language_handling.patch7.39 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Doesn't everything in views happens upon a request?

 * Note that this function is provided for legacy code that needs to get e.g.
 * the interface language outside the scope of a request. Code that runs within
 * the scope of a request should call
 * drupal_container()->get('language_manager')->getLanguage($type)
 * directly.
 */
function language_manager()...
tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » tim.plunkett
Status: Needs review » Needs work

Trying to figure out what to do about drupal_container()->set(LANGUAGE_TYPE_INTERFACE, $cached_language);

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

dawhener not everything try it yourself

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

I committed http://drupalcode.org/project/views.git/commit/3a5e17f for now, and added @todo's for the set() calls.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented

did not verify but I'm 100% sure tests are broken again:

replace "language_manager" with "language"

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs work » Fixed

http://drupalcode.org/sandbox/damiankloip/1685040.git/commit/0de55ad

Please please let this stay fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.