Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.See http://drupal.org/node/1678914
More stuff needs to be converted to number probably but this is a start :)
| Comment | File | Size | Author |
|---|---|---|---|
| 0002-remove-custom-positive-number-validation.patch | 3.66 KB | aspilicious | |
Comments
Comment #1
aspilicious CreditAttribution: aspilicious commentedadding tag
Comment #2
dawehnerJust in general, do you think it would make sense to convert the options for the filters as well, so if you have exposed filters actual users get a better UI on moderation devices?
Comment #3
aspilicious CreditAttribution: aspilicious commentedyes that would make sense. I'm not sure how to find all these number textfields. Probably should wait for the annotation stuff
Comment #4
damiankloip CreditAttribution: damiankloip commentedYeah, I think this might be another one to wait until we have all the plugins in views 8.x
Comment #5
dawehnerRegarding #2: Let's not waste work as it is a new feature.
#1321640: Numeric exposed filter form has no validation for required inputs or numeric values is for example an issue to validate the numbers. I'm wondering why the #size is removed in the patch?
Comment #6
aspilicious CreditAttribution: aspilicious commentednumber stuff has a standard size (smaller than old school textfields)
Comment #7
tim.plunkettJust a note, I moved that function to views.module to let tests pass, see http://drupalcode.org/sandbox/damiankloip/1685040.git/commit/b044999
I'm definitely okay with moving it.
Comment #8
dawehnerCommitted to the 8.x-plugins branch, as it is much easier not to have to tackle with the merge.