Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I did an experimental patch. Wanted to know how module dependencies get handled :)
More information: http://drupal.org/node/1710766
Comment | File | Size | Author |
---|---|---|---|
#11 | views-1711640-11.patch | 9.8 KB | tim.plunkett |
#8 | 1711640-8.patch | 9.72 KB | damiankloip |
#6 | 1711640-6.patch | 9.75 KB | damiankloip |
0001-convert-setup-calls.patch | 9.94 KB | aspilicious | |
Comments
Comment #2
aspilicious CreditAttribution: aspilicious commentedadded tag
Comment #3
aspilicious CreditAttribution: aspilicious commented0001-convert-setup-calls.patch queued for re-testing.
Comment #5
tim.plunkettThis should be rerolled with the docblocks we agreed on for core.
Comment #6
damiankloip CreditAttribution: damiankloip commentedre rolled with these changes in.
Comment #7
tim.plunkettThere should be a blank line after the class before the first comment.
Comment #8
damiankloip CreditAttribution: damiankloip commentedOops, here you go.
Comment #9
dawehner#8: 1711640-8.patch queued for re-testing.
Comment #11
tim.plunkettViewsSqlTest was enabling views_ui already, so we are able to remove it from its child classes.
Comment #12
damiankloip CreditAttribution: damiankloip commentedNice.
Comment #13
aspilicious CreditAttribution: aspilicious commentedwhat about views_test?
Comment #14
tim.plunkettPagerTest::setUp()
passed "views_test", but its parent isViewsSqlTest::setUp()
, which completely ignored its child classes and only enabled views and views_ui anyway. So the module was never used by the test.Comment #15
aspilicious CreditAttribution: aspilicious commentedin that case...
Comment #16
tim.plunketthttp://drupalcode.org/project/views.git/commit/e0e125c