Currently join handlers are pure classes, but wouldn't it make sense to convert them to a type of views plugin as well?

This would at least unify the way how to integrate things in hook_views_data

CommentFileSizeAuthor
#6 1706258-join-plugins.patch19.12 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Issue tags: +VDC

.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review

There is a branch called "join-plugins" in the sandbox, so feel free to have a look at.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

I added a couple use statements that were missing, but I'm getting:

Fatal error: Call to undefined method stdClass::construct() in /Users/tim/www/d8/sites/all/modules/views/lib/Drupal/views/Plugin/views/relationship/RelationshipPluginBase.php on line 143 and I haven't debugged it yet.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented

Currently joins don't have set_definition etc. so i had to write an extra helper function to get a join plugin.

This time a basic relationship works.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Title: Conver join handlers to plugins » Convert join handlers to plugins
dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
FileSize
1706258-join-plugins.patch19.12 KB

Let's see what the testbot tells us about the patch

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs review » Fixed

Let's get this in now, so we can work on other stuff.

Automatically closed -- issue fixed for 2 weeks with no activity.