make param in db_rename_table() clearer [#1703184]

API page: http://api.drupal.org/api/drupal/includes%21database%21database.inc/func...

Enter a descriptive title (above) relating to db_rename_table, then describe the problem you have found:

> $table: The table to be renamed.

Given Drupal's love of monster arrays, this parameter could be construed as being a schema API array. It would be clearer to say 'the current name of the table to rename'.

Comment	File	Size	Author
#7	make-param-in-db_rename_table-clearer-1703184-1.patch	796 bytes	salah1
#7
#3	make-param-in-db_rename_table-clearer-1703184-1.patch	775 bytes	salah1
#3

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 27 July 2012 at 23:12

Sounds like a good suggestion. Good Novice patch project... ah, you already tagged it. Thanks!

Comment #2

salah1

VA, U.S

CreditAttribution: salah1 commented 30 July 2012 at 22:33

Assigned:

Unassigned

» salah1

Comment #3

salah1

VA, U.S

CreditAttribution: salah1 commented 31 July 2012 at 19:47

Status:

Active

» Needs review

File	Size
make-param-in-db_rename_table-clearer-1703184-1.patch	775 bytes

Comment #4

joachim CreditAttribution: joachim commented 31 July 2012 at 19:56

Status:

Needs review

» Reviewed & tested by the community

Perfect! Thanks!

Comment #5

salah1

VA, U.S

CreditAttribution: salah1 commented 1 August 2012 at 13:39

Working on the backport to D7

Comment #6

jhodgdon

she/her

English

CreditAttribution: jhodgdon commented 1 August 2012 at 16:12

Version:	8.x-dev	» 7.x-dev
Status:	Reviewed & tested by the community	» Patch (to be ported)

Usually it's best to wait until the 8.x patch is actually committed before working on a 7.x patch. Sometimes, the committer finds something wrong and sets the issue back to "needs work", and sometimes the same patch can be applied to 7.x (by ignoring path segments), so there's no need to make a new patch at all.

Anyway, I just committed the above patch to 8.x, thanks! I

think David is working on a 7.x release this morning, so I don't want to commit anything to 7.x at the moment... And in this case the function is in a completely different file for D7 so it does need to be ported.