Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Apparently theme_image_style was broken at some point, but http://drupalcode.org/project/drupal.git/commitdiff/fbd6af0b fixed it part way. But it has no test coverage, and is currently still broken.
I found this while working on #1175764-7: Have theme('image_style') inject the style name as a class
| Comment | File | Size | Author |
|---|---|---|---|
| #4 | drupal-1696416-4.patch | 1.75 KB | tim.plunkett |
| #1 | drupal-1696416-1-tests.patch | 1.3 KB | tim.plunkett |
| #1 | drupal-1696416-1-combined.patch | 1.74 KB | tim.plunkett |
Comments
Comment #1
tim.plunkettSee attached.
Comment #2
sunComment #3
BerdirThe change makes sense is required for theme() to pick the right arguments passed to that function. I'm not actually sure if the referenced commit is a partial fix of an existing bug or if it introduced the bug by doing an incomplete change but that doesn't really matter.
Oh, and if you think URI is a weird thing to pass to a image style theme function, that's being discussed in #1643890: Change URI to SRC in theme_image and similar.
Tests prove that this fixes the issue and is currently broken, so I think this is ready to go. timplunkett also confirmed to me in IRC that the grammar in the assertion message is valid which looked a bit strange to me as a non-native speaker.
Comment #4
tim.plunkettOkay I double checked with xjm and my grammar was a bit off after all.
Leaving RTBC, since I only changed the assertion message.
Comment #5
Dries CreditAttribution: Dries commentedCommitted to 8.x. Thanks!
Comment #6.0
(not verified) CreditAttribution: commentedUpdated issue summary.