JSHint simpletest [#1684868]

Follow-up of #1664940: [Policy, patch] Decide on JSHint configuration and part of #1415788: Javascript winter clean-up

Run jshint on the files with the configuration from the parent issue or use jshint.com with the following options:

/*jshint forin:true, noarg:true, eqeqeq:true, undef:true, curly:true, browser:true, expr:true, latedef:true, newcap:true, trailing:true */
/*global Drupal, jQuery */

Fix any warnings or errors the tool finds.
Check manually that the fixes did not break any functionalities
Create patch and upload for the testbot.

Files: simpletest/simpletest.js

Comment	File	Size	Author
#4	core-js-jshint-simpletest-1684868-4.patch	1.81 KB	nod_
#4
#2	core-js-jshint-simpletest.patch	1.49 KB	nod_
#2

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

nod_

French

Lille

CreditAttribution: nod_ commented 14 July 2012 at 14:32

core/modules/simpletest/simpletest.js: line 79, col 12, Don't make functions within a loop.
core/modules/simpletest/simpletest.js: line 96, col 10, Don't make functions within a loop.

Comment #2

nod_

French

Lille

CreditAttribution: nod_ commented 14 July 2012 at 16:35

Status:

Active

» Needs review

File	Size
core-js-jshint-simpletest.patch	1.49 KB

works for me

Comment #3

droplet CreditAttribution: droplet commented 14 July 2012 at 16:39

Status:

Needs review

» Needs work

+++ b/core/modules/simpletest/simpletest.jsundefined
@@ -69,17 +69,15 @@ Drupal.behaviors.simpleTestSelectAll = {
+          if ($('#' + testCheckboxes[i]).attr('checked')) {

might be use prop() ?