This is the "Tags" field help text (default installation):
Enter a comma-separated list of words to describe your content.
For most non-tech users, they think it only allowed this format:
Apple, Orange, Apple Pie
At some case with comma, they will try to type in
"Summer2012"
( because most of system out there are only supported very basic comma-separated list. )
But in Drupal, it also supported:
"Doe, John", "Summer, 2012"
turn into:
sDoe, John
Summer, 2012
related: (#1329742: Autocomplete with tagging silently discards invalid input)
Comment | File | Size | Author |
---|---|---|---|
#61 | drupal-1680022-61.patch | 685 bytes | alexkb |
#58 | drupal-1680022-41.patch | 733 bytes | ellishettinga |
#20 | drupal-1680022-6.patch | 723 bytes | ellishettinga |
#20 | interdiff-drupal-1680022-5-6.txt | 780 bytes | ellishettinga |
#16 | drupal-1680022-5.patch | 720 bytes | ellishettinga |
Comments
Comment #1
StuartJNCC CreditAttribution: StuartJNCC commentedI suspect most people don't even realise that "Apple pie" is OK!
Whatever wording is decided on, I suggest using an example showing both a phrase containing a space as well as one containing a comma.
E.g.:
I think going into the realm of the
"and ""this"" w,o.rks"
example here is over-kill for most people.Comment #2
barickx CreditAttribution: barickx commentedComment #3
barickx CreditAttribution: barickx commentedI update the description field as suggested in comment #1
Comment #4
Marty2081 CreditAttribution: Marty2081 commentedThe patch applies fine. Tested it doing a clean "standard" install (this patch obviously has no effect on an already installed D8 instance). The description is changed correctly according to comment #1.
RTBC in my opinion.
Comment #5
cristiroma CreditAttribution: cristiroma commentedI also tested it and it works with a clean "standard" installation profile.
+1 for RTBC
Comment #6
ellishettinga CreditAttribution: ellishettinga commentedOK
This patch obviously has no effect on an already fresh installed D8 instance.
But applied in a simplytest installation the description is changed correctly according to comment #1.
Comment #7
XanoI would not use "e.g.", because it is a language-specific abbreviation that may confuse people. I propose using "for example" instead. After that it can be put back on RTBC again.
Comment #8
ellishettinga CreditAttribution: ellishettinga commentedComment #9
ellishettinga CreditAttribution: ellishettinga commentedadded the comment created in #7 in a new patch
Comment #10
ellishettinga CreditAttribution: ellishettinga commentedComment #11
tstoecklerLooks great, thanks!
I'm sending this for a quick review by the usability team as this is a string that most people installing Drupal 8 will see. I personally find nothing wrong with it.
Comment #12
yoroy CreditAttribution: yoroy commented177 characters is a bit much no? Almost tripling the length of the description to explain the less common use case is not an improvement. What about:
Comment #13
ellishettinga CreditAttribution: ellishettinga commentedI miss the info about the comma-separated list of words. When I read 'Describe your content' I would probably start typing a description, not a list of words.
What about this:
'Enter a comma-separated list of words to describe your content. For example: Apple, Orange, Apple Pie, "Cherry, Morello"'
Comment #14
yoroy CreditAttribution: yoroy commentedYep, that works too and makes is a bit more specific, that's good.
Comment #15
ellishettinga CreditAttribution: ellishettinga commentedComment #16
ellishettinga CreditAttribution: ellishettinga commentedChanged the text as suggested in #13
Comment #17
BarisW CreditAttribution: BarisW commentedI must say that "Cherry, Morello" doesn't make sense to me. What if we use cities as example, so we could give an example where the comma actually makes sense?
'Enter a comma-separated list of words to describe your content. For example: Amsterdam, Boston, "Cleveland, Ohio", New York'
Comment #18
ellishettinga CreditAttribution: ellishettinga commentedYes I must say I had the same 'problem' but could not come up with a better fruit example.
I think your cities example is more clear.
I will create a new patch.
Comment #19
yoroy CreditAttribution: yoroy commentedGood point, the cities example is better to translate as well. I find all examples mostly examples of how *not* to use tags. Are there more than one Clevelands?
Comment #20
ellishettinga CreditAttribution: ellishettinga commentedAdapted according to #17
It now says:
Comment #21
BarisW CreditAttribution: BarisW commentedThere are multiple Clevelands, see http://en.wikipedia.org/wiki/Cleveland_(disambiguation)
Maybe we can remove one city of this list to make it fit on one line, see screenshot.
Comment #22
yoroy CreditAttribution: yoroy commentedThanks for clarifying. But fit on one line on your computer? We don't optimize for specific screen sizes :-)
I think this is good to go.
Comment #23
BarisW CreditAttribution: BarisW commentedAh, my bad. I could have resized the window. Sigh. :p
Comment #24
XanoThe example now references three cities and one USA state (New York), which is inconsistent.
Also, we now have one Dutch city with three places from the US, so we might want to rework this into a more worldly example.
Comment #25
ellishettinga CreditAttribution: ellishettinga commentedThe current description may be inconsistent but as an example it works for me.
Do you have a suggestion to improve it to be more consistent?
Comment #26
StuartJNCC CreditAttribution: StuartJNCC commentedNot sure I find it inconsistent - I though New York is the name of a city (as well as a state), but I'm British, so what would I know ...
How about just one example of each and going more international:
Enter a comma-separated list of words to describe your content. For example: Amsterdam, Buenos Aires, "Cleveland, Ohio"
Comment #27
XanoNew York can be either the state or the city, but is (I believe) generally used to refer to the state. New York, NY or New York, New York is the city. For the Dutch among us: see Utrecht and Groningen.
Buenos Aires is both a province and a city as well. What about Amsterdam, Kiev, "Cleveland, Ohio"?
Comment #28
StuartJNCC CreditAttribution: StuartJNCC commentedI thought that the idea was to have one example of a single word (Amsterdam), one of a phrase with white space (New York, Buenos Aires, Mexico City ... whatever) and one example of a phrase with an embedded comma ("Cleveland, Ohio"). So Kiev does not work. Why does it matter that it is a state as well as a city?
Comment #29
XanoWe should try to avoid being ambiguous, because it may both make the meaning of the example less clear, and confuse translators.
Comment #30
StuartJNCC CreditAttribution: StuartJNCC commentedOK, but I do think that giving these three sorts of example is important. Going back to my comment in #1, I don't think the fact that you can use a phrase containing white space is obvious to people. Other software I use frequently (e.g. Picassa, Blogger) uses white space as the delimiter in these sorts of tag lists, so I would not automatically realise that New York is useable as a tag.
Comment #31
yoroy CreditAttribution: yoroy commentedHaving the 3 examples like StuartJNCC says in #28 is the important bit. All the rest seems hardly relevant to nitpick so much. "New Delhi"?
Comment #32
ellishettinga CreditAttribution: ellishettinga commentedNew Delhi apparently is also the name of a district. Maybe Mexico City #28 is the best suggestion then:
Comment #33
XanoComment #34
ellishettinga CreditAttribution: ellishettinga commentedThanks Xano..
You connected me to this issue last Friday on the 'get involved with core sprint' in Prague.
It's still assigned to me like you told me to.
So...why won't you let me finish it?
Comment #35
XanoI posted another patch, because there had been quite a few comments without one, and keeping patches up-to-date makes it easier for people to try the change and test it in a real Drupal installation. Besides that, during mentoring sprints we try to let mentees review each other's patches. Since you did not have a 'buddy' at the sprint whom you collaborated with (as far as I know), my thinking was that an updated patch from someone else would help you better understand the issue process. It just so happened that I was the first one to decide to re-roll the patch based on the latest comments.
Here's a screenshot for easier review:
The final period is missing.
Comment #36
yoroy CreditAttribution: yoroy commentedThanks for the screenshot. It is still a lot of text. We could halve it once more by replacing the first sentence and the "for example" bit with "These three all work:"
Comment #37
BarisW CreditAttribution: BarisW commentedOr: "Enter comma-separated words to describe your content, like: Boston, Mexico City, "Cleveland, Ohio".
Also, I'm missing a dot on the end of the line. @ellis: go girl!
Comment #38
XanoWhat about something like
Enter a comma-separated list of words, such as <em>Amsterdam, Mexico City, "Cleveland, Ohio"</em>.
?Because all three tags are emphasized, this might also make it clearer that the quotes are most definitely part of the field value.
// Edit: I just realized that using HTML tags in the description will probably not work.
Comment #39
yoroy CreditAttribution: yoroy commentedWell, my point is that the 'enter words to describe your content' is documenting what tagging is, which I don't think we should be explaining here.
Comment #40
ellishettinga CreditAttribution: ellishettinga commentedComment #41
XanoGood point. To clarify: we have standards that say we should not explain how user interface elements work. On the other hand, does that phrase not have a second purpose here, which is to introduce the example?
Comment #42
yoroy CreditAttribution: yoroy commentedHence the "These all work:"
Comment #43
ellishettinga CreditAttribution: ellishettinga commentedThe latest patch posted in #40 includes this:
In #42 yoroy suggested:
This is shorter but lacks the 'comma-separated' info that I think we should keep for novice Drupal users?
Comment #44
droplet CreditAttribution: droplet commentedThe help text used on ONE default Tag field only. I'd say
OR
Both are good enough.
This example tells me I can type in random words / sentences in non comma-separated formats.
Comment #45
Bojhan CreditAttribution: Bojhan commentedI am not convinced. Do we actually need to educate people about this? It seems like an edge case, and we don't need to educate about edge cases in a main UI like this
Comment #46
StuartJNCC CreditAttribution: StuartJNCC commentedEvery user who adds content is going to hit this. Tags are fairly central to a CMS. They are one of the main ways that relevant content is grouped and discovered. Seems to me it is worth a line or two of screen space and I do think the examples help. IMO the second wording in #44 strikes a reasonable balance between brevity and helpfulness.
Comment #47
Bojhan CreditAttribution: Bojhan commentedThere is no way, every user who adds content is going to hit this. It will only hit the very few users who want to add a tag with quotation marks in it. I still this think is a won't fix. We don't have to explain all entry possibilities for every field.
Comment #48
XanoNote that this issue only aims to change the description for the default field in the Standard install profile. It will never appear anywhere else, so any site installed using another profile will not show it, nor will sites on which a tagging field was created after installation.
Comment #49
bsnodgrass CreditAttribution: bsnodgrass commentedSeems like the current status on this is reasonable. I agree with Xano and Bojhan.
Comment #50
XanoBojhan and I have not agreed on anything. Also, core issues can only be set to fixed by core maintainers.
Comment #51
ellishettinga CreditAttribution: ellishettinga commentedComment #52
bsnodgrass CreditAttribution: bsnodgrass commentedI meant to say that the latest patch provides a reasonable fix to this.
beg your pardon on setting fixed... won't happen again.
Comment #53
XanoI'm sorry for being a bit snappy in my previous post. Please take a look at Status settings for an issue, so you get a good idea of how statuses are used.
Comment #53.0
Xanotypo
Comment #54
ellishettinga CreditAttribution: ellishettinga commented40: drupal-1680022-40.patch queued for re-testing.
Comment #55
droplet CreditAttribution: droplet commentedUnlike other CMS system or web application, Drupal supports more tagging styles than others. Many web application they even don't support SPACE:
"Amsterdam, Mexico City"
will be
Amsterdam
Mexico
City
Comment #56
droplet CreditAttribution: droplet commented40: drupal-1680022-40.patch queued for re-testing.
Comment #58
ellishettinga CreditAttribution: ellishettinga commentedcreated a new patch 41 containing:
Enter a comma-separated list. For example: Amsterdam, Mexico City, "Cleveland, Ohio".
Comment #59
XanoWhat does the bot say?!
Comment #60
BarisW CreditAttribution: BarisW commentedI am very happy with this patch. I've had several occasions in the past where I needed a comma in my tag and I didn't know how to do this. It's not only happening for Cities, but also for names: "Doe, John". Or even "Summer, 2012". A little bit of explanation for users here wouldn't hurt.
Comment #61
alexkb CreditAttribution: alexkb commentedPatch #58 from @ellishettinga looks good to me, but doesn't apply against latest version of 8.x and unnecessarily adds spacing to the end. Anyway, attached is a re-roll. #drupalsouth
Comment #62
tstoecklerI also like this patch but I just want to remind people that @Bojhan from the UX team was explicitly against adding this information above. His decision can certainly be overruled but in general our UX team and @Bojhan in particular has a pretty good feel for what might or might not confuse the 80%. So I think for this patch to go in, we need to gather some arguments for this (or close this again).
Comment #63
alexkb CreditAttribution: alexkb commentedMissed those comments from @Bojhan, thanks for pointing it out. Perhaps this extra help information should be provided in a tour implementation for taxonomy?
Comment #64
droplet CreditAttribution: droplet commentedAs BarisW also point out, we also used it in "Doe, John". Or even "Summer, 2012". It's a very common usages.
Comment #65
droplet CreditAttribution: droplet commentedComment #66
catchGiving Bojhan another chance to comment.
Comment #67
Bojhan CreditAttribution: Bojhan commentedI don't think this is necessary, having it in a or outside standard profile doesn't matter to me. However it also doesn't make it longer or more complex so I am fine with putting this in.
Comment #68
webchickThat period bothered me, since I couldn't remember all the rules, but in American English I believe it should be *inside* the quotes and in UK English (which we generally avoid using) it should be *outside* but putting it *inside* makes the example confusing and AHHHHH.
So instead of getting stuck in analysis paralysis, I just removed the period, since it's not a sentence, anyway. :P And!
Committed and pushed to 8.x. Thanks! :D