Moving 'default_nodes_main' to a separate node_form_system_site_information_settings_alter() will change a form structure because it makes no sense to have a fieldset with only one 'site_frontpage' field in fieldset. Also this setting used in taxonomy pages so we could have other variable for them

$form['front_page'] = array(
    '#type' => 'fieldset', 
    '#title' => t('Front page'),
  );
  $form['front_page']['default_nodes_main'] = array(
    '#type' => 'select', 
    '#title' => t('Number of posts on front page'), 
    '#default_value' => variable_get('default_nodes_main', 10), 
    '#options' => drupal_map_assoc(array(1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 15, 20, 25, 30)), 
    '#description' => t('The maximum number of posts displayed on overview pages such as the front page.'),
  );
  $form['front_page']['site_frontpage'] = array(

Proposed

  $form['site_frontpage'] = array(
CommentFileSizeAuthor
#1 drupal8.node-default-main.1.patch2.71 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

sun’s picture

Component: system.module » node.module
Priority: Normal » Major
Status: Active » Needs review
FileSize
2.71 KB

Thanks for creating this issue, @andypost! :)

KISS!

And no, not converting to the config system.
And no, not changing the variable name.
And no, not performing any additional improvements.

Just get this out of the way.

andypost’s picture

Status: Needs review » Reviewed & tested by the community

Ok :) This changes an order of form fields, anyway let's get this commited and finish #1496542: Convert site information to config system

I think this issue should have follow-up to actually fix this variable.

webchick’s picture

Status: Reviewed & tested by the community » Fixed

I'm not at all sure why this is major, but change makes sense.

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xjm’s picture

Component: node.module » node system
Issue summary: View changes