Replace all jQuery.each() with filtered for loop

Also be sure to look for this.each() when jQuery is 'this'.

That's how real men do it.

I tested, worked for me, except that I can't seem to find a page where menu.admin.js is added (so yeah, field_ui.js worked).

#3: for.patch queued for re-testing.

I was expecting a fail to apply error but not random testbot failure. I guess it doesn't need a reroll then.

Problem was that in menu.admin.js the options variable is an object, not an array, changed to for loop to a for in loop.

very minor thing, is it possible to replace the variable name i to value?

(edit) and more importantly, the jquery selector needs to be out of the loop that's pretty doggy like that.

+++ b/core/modules/menu/menu.admin.jsundefined
@@ -35,11 +35,13 @@ Drupal.menu_update_parent_list = function () {
+          $('fieldset#edit-menu #edit-menu-parent').append(

You mean this selector right? That's the result of a shameless copy-paste and trying to do a quick-fix on replacing the loop ;-)
new patch attached

+++ b/core/modules/menu/menu.admin.jsundefined
@@ -31,15 +31,18 @@ Drupal.menu_update_parent_list = function () {
+      var $selectfield = $('fieldset#edit-menu #edit-menu-parent');

Just on a side note: can't we change this to $('#edit-menu-parent') since HTML ids are supposed to be unique anyway?

And an other question, not necessarily related to this issue, but I've had it on my mind since a while now:
What is best practice:

$('.classone .classtwo .anotherclass');

or

$('.classone').find('.classtwo').find('.anotherclass');

fixed one for that should have been a for in loop.

Also in field_ui.js line 86, there's a this.each() where this is a jQuery object. Should this be changed to a for loop?

I talked with @seutje about it, and we both seemed to think this was a valid use case to use the jQuery.each() function, but we would like some feedback on this (@nod_ ?)

Oh yeah we're not replacing the jQueryElement.each just the $.each.

For now :)

if you rename value as index in menu.admin.js that's RTBC :)

the menu.admin.js changes were incorporated in #1751398: Selectors clean-up: menu module, along with some others, so I'm rerolling this one without that bit, so either won't break if the other goes in first.

damn status

I'd put it on RTBC if I hadn't worked on this patch as well :-( ;-)

In other words: Looks good to me...

#15: 1660952-jquery.each-15.patch queued for re-testing.

Still applies and still a proper fix.

Committed/pushed to 8.x, thanks!