book pages dishonor node_access [#16462]

Book pages slighty disobey the node_access system because they always return a value for book_access('update'). This simple patch causes us to use node_access when the user has a chance of being able to update the current page.

Comment	File	Size	Author
#3	book_26.patch	1.37 KB	moshe weitzman
#3
#1	book_25.patch	882 bytes	moshe weitzman
#1
	tree.diff	921 bytes	moshe weitzman

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 3 February 2005 at 16:34

File	Size
book_25.patch	882 bytes

i had the conditions reversed. thanks jonbob.

Comment #2

sulleleven CreditAttribution: sulleleven commented 3 February 2005 at 17:36

i noticed this a while back... thnx for the patch.
would a similar reason apply to the project modules issue nodes?

Comment #3

moshe weitzman CreditAttribution: moshe weitzman commented 3 February 2005 at 18:11

File	Size
book_26.patch	1.37 KB

this version adds a 'revision pending' message as needed at bottom of the node view. the lack of this indicator confuses authors on drupal.org why they have no edit tab, and may remind recent editors why their edits are not showing up yet.

sorry for mixing two unrelated ideas in one patch. at least they affect the same single file