Convert query tests to PSR-0

CommentFileSizeAuthor
#16 views-1641694-16.patch29.79 KBtim.plunkett
#16 interdiff.txt1.27 KBtim.plunkett
#15 views-1641694-15.patch29.96 KBtim.plunkett
#14 1641694.patch29.89 KBdawehner
#11 views_query_test_psr0-1641694-11.patch35.47 KBAnonymous (not verified)
#3 1641694.patch33.05 KBRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Issue tags: +PSR-0

Yeah this issue should be postponed until all other test cases are converted

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented

Why? Or: Is now the time? Ah ... so this is a Views issue.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Needs review
FileSize
1641694.patch33.05 KB

How's this?

Status: Needs review » Needs work

The last submitted patch, 1641694.patch, failed testing.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

We might want to wait for #1637736: Convert user interface test to PSR-0, I think that might be last of them.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented

and maybe #1637668: Convert plugin tests to PSR-0

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
Issue tags: -PSR-0, -VDC

#3: 1641694.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1641694.patch, failed testing.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review

#3: 1641694.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +PSR-0, +VDC

The last submitted patch, 1641694.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented
Status: Needs work » Needs review
FileSize
views_query_test_psr0-1641694-11.patch35.47 KB

The patch needed a little updating. It may go a little too far, as the use statements in the other Views have been updated, to (hopefully) allow the tests to pass.

Status: Needs review » Needs work

The last submitted patch, views_query_test_psr0-1641694-11.patch, failed testing.

Anonymous’s picture

Anonymous (not verified) CreditAttribution: Anonymous commented

Loads of issues with my last patch.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Needs work » Needs review
FileSize
1641694.patch29.89 KB

I have a try as well.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
views-1641694-15.patch29.96 KB

Here's another attempt.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
FileSize
interdiff.txt1.27 KB
views-1641694-16.patch29.79 KB

Okay, I think this one is good to go, if it passes tests.

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Status: Needs review » Fixed

http://drupalcode.org/project/views.git/commit/94ca4f1

Automatically closed -- issue fixed for 2 weeks with no activity.