tplify search module [#164032]

These three modules that look like they could use some conversions. As far as modules go, I don't think anything else needs converting.

- search --Currently working
- tracker --Maybe, maybe not?
- aggregator --postponed?

Converted and commited:

- poll: http://drupal.org/node/162871 --part of a bigger patch
- user: http://drupal.org/node/161510
- profile: http://drupal.org/node/162134
- block: http://drupal.org/node/159936
- forum: http://drupal.org/node/158536
- comment: http://drupal.org/node/160589

Converted and still open:

- theme.inc: http://drupal.org/node/141914
- book: http://drupal.org/node/160200
- actions: http://drupal.org/node/159862

Other related patches

- maintenance tpl: http://drupal.org/node/141727 --core commiters, please take a look.
- Related to forum templates. Adds ID's to the forum templates: http://drupal.org/node/53905

I'll change this into an issue for search.module once I have a patch up.

Comment	File	Size	Author
#24	tplify_search_2.patch	16.49 KB	Crell
#24
#23	tplify_search_0.patch	16.48 KB	ChrisKennedy
#23
#22	tplify_search.patch	9.64 KB	ChrisKennedy
#22
#21	tplify_search_1i_0.patch	16.63 KB	dmitrig01
#21
#19	tplify_search_2i.patch	0 bytes	dmitrig01
#19
#14	tplify_search_1i.patch	16.63 KB	dvessel
#14
#13	tplify_search_1g_0.patch	16.64 KB	dvessel
#13
#12	tplify_search_1h.patch	15.73 KB	Wim Leers
#12
#11	tplify_search_1g.patch	8.89 KB	Wim Leers
#11
#10	tplify_search_1f.patch	15.43 KB	dvessel
#10
#9	tplify_search_1e.patch	15.98 KB	dvessel
#9
#8	tplify_search_1d.patch	15.96 KB	dvessel
#8
#4	tplify_search_1c.patch	16.12 KB	dvessel
#4
#3	tplify_search_1b.patch	9.11 KB	dvessel
#3
#1	tplify_search_1.patch	9.09 KB	dvessel
#1

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

dvessel CreditAttribution: dvessel commented 7 August 2007 at 18:01

Title:	tplify * placeholder	» tplify search module
Status:	Active	» Needs review

File	Size
tplify_search_1.patch	9.09 KB

Lots of changes..

Name changes:
- *search_page to *search_results
- - It wasn't actually a page. All it does is wrap the results. Form fields above it are not even part of this template.
- *search_item to *search_result
- - I think it makes more sense.

Removed '_keys' suffix for the form ID. They were already unique and it made the variable key for the .tpl longer then it needed to be.

Search forms broken up for each input. Makes it easier to replace a submit button with a graphic. This is done often.

Template suggestions provided based on type of search. "user" or "node". Class also added in the parent template based on type.

Small modification to node.module so $result['extra'] array that gets passed to template_preprocess_search_result() are all keyed. This makes it easier for themers to alter the $info_split array inside search-result.tpl.php. (search result meta information).

Removed a ruleset for search.css. ".search-form p" doesn't even exist.

For the theme functions to work, another patch must be applied due to a bug.

http://drupal.org/node/164351#comment-285126

Thanks for reviewing.

Comment #2

dvessel CreditAttribution: dvessel commented 7 August 2007 at 18:11

Priority:

Normal

» Critical

Comment #3

dvessel CreditAttribution: dvessel commented 7 August 2007 at 18:19

File	Size
tplify_search_1b.patch	9.11 KB

Small fix on template suggestion.

Comment #4

dvessel CreditAttribution: dvessel commented 7 August 2007 at 18:25

File	Size
tplify_search_1c.patch	16.12 KB

Forgot the -N parameter. Here it is again with the .tpl files.

Comment #5

rstamm CreditAttribution: rstamm commented 8 August 2007 at 08:55

Status:

Needs review

» Needs work

Quick review:

CVS Id tags broken and missing blank line after cvs id tags

Comment #6

dvessel CreditAttribution: dvessel commented 8 August 2007 at 17:17

Status:

Needs work

» Needs review

Thanks for looking but the cvs id tags are not broke. They are new files. It'll automatically get converted once it's commited. And I believe the blank line isn't an issue since my other patches that were formed the same way got committed.

Comment #7

rstamm CreditAttribution: rstamm commented 9 August 2007 at 00:43

The cvs id tag won't converted because the tag is $Id$ and not $Id.
The blank line is needed to make the files consistent.

Please take a look at http://drupal.org/node/164935. Thanks

Comment #8

dvessel CreditAttribution: dvessel commented 9 August 2007 at 01:40

File	Size
tplify_search_1d.patch	15.96 KB

Okay, still a relative CVS noob.

Comment #9

dvessel CreditAttribution: dvessel commented 29 August 2007 at 17:30

File	Size
tplify_search_1e.patch	15.98 KB

Rerolled for latest head.

Comment #10

dvessel CreditAttribution: dvessel commented 30 August 2007 at 01:05

File	Size
tplify_search_1f.patch	15.43 KB

And another update to keep up with head.

Comment #11

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 30 August 2007 at 09:55

File	Size
tplify_search_1g.patch	8.89 KB

Patch works as advertised. I've tried every .tpl.php file and they all worked. I didn't test every available variable though.

I also went through the descriptions in each tpl.php file. Minor fixes:
- spelling ("existance" -> "existence", "dependant" -> "dependent")
- style (lines longer/shorter than 78 characters)

Updated patch attached.

Comment #12

Wim Leers

Ghent 🇧🇪🇪🇺

CreditAttribution: Wim Leers commented 30 August 2007 at 10:09

File	Size
tplify_search_1h.patch	15.73 KB

The new files weren't included, my bad. Updated patch.

Comment #13

dvessel CreditAttribution: dvessel commented 6 September 2007 at 17:21

File	Size
tplify_search_1g_0.patch	16.64 KB

Thanks Wim Leers, here it is again after the split patch..

I'd say this is ready, please before it breaks again... :)

Comment #14

dvessel CreditAttribution: dvessel commented 6 September 2007 at 17:26

File	Size
tplify_search_1i.patch	16.63 KB

arg, left a stray drupal_rebuild_theme_registry()..

Comment #15

dmitrig01 CreditAttribution: dmitrig01 commented 17 September 2007 at 04:02

why did you change node.module's node_invoke_nodeapi

Comment #16

dvessel CreditAttribution: dvessel commented 17 September 2007 at 18:22

It's because what I mentioned above:

Small modification to node.module so $result['extra'] array that gets passed to template_preprocess_search_result() are all keyed. This makes it easier for themers to alter the $info_split array inside search-result.tpl.php. (search result meta information).