Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.Another one where page handlers aren't a large chunk of the file. Ah well.
| Comment | File | Size | Author |
|---|---|---|---|
| #7 | filter_21.patch | 31.19 KB | Crell |
| #6 | filter_20.patch | 31.19 KB | Crell |
| #4 | filter_19.patch | 31.18 KB | Crell |
| #2 | filter_18.patch | 31.18 KB | Crell |
| filter_17.patch | 24.36 KB | Crell | |
Comments
Comment #1
Dries CreditAttribution: Dries commentedThis patch no longer applies ...
Comment #2
Crell CreditAttribution: Crell commentedTake 2. Bumping to critical since this is a required module.
Comment #3
Wim LeersOn a fresh HEAD checkout, this happens:
Comment #4
Crell CreditAttribution: Crell commentedBah! People need to stop fixing bugs when I'm rearranging code. :-)
Comment #5
Wim LeersTesting all input filter admin/user forms and the filter tips revealed no issues.
Coding/commenting style issues:
filter.admin.inc:
- line 10: should wrap at column 78, no dot at the end of the sentence, "Displays" shouldn't be capitalized on the first character.
- line 303: "@seefilter..." should be "@see filter..."
- (very minor) lines 24, 42, 306, 327: needs a dot at the end
Comment #6
Crell CreditAttribution: Crell commentedThe periods and such aren't part of this issue, but I've been cleaning up docs otherwise with these patches so what the heck.
Comment #7
Crell CreditAttribution: Crell commentedKeeping up with HEAD. Again, I'm kinda worried that nothing seems to have broken. :-)
Comment #8
Dries CreditAttribution: Dries commentedWe need filters on nearly all pages so let's make sure to slice this up.
Comment #9
(not verified) CreditAttribution: commented