Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in pager.test over to PSR-0.
Comment | File | Size | Author |
---|---|---|---|
#13 | 1598594_13_pager_psr.patch | 1.89 KB | aspilicious |
#8 | 0001-Pager-PSR-0.patch | 1.93 KB | cosmicdreams |
#3 | 0001-Pager-PSR-0.patch | 1.88 KB | cosmicdreams |
#2 | 0001-commit-change-to-pager.test-for-PSR-0.patch | 1.93 KB | cosmicdreams |
#1 | 1598594_1_pager_psr.patch | 24.93 KB | cosmicdreams |
Comments
Comment #1
cosmicdreams CreditAttribution: cosmicdreams commentedFirst Try
Comment #2
cosmicdreams CreditAttribution: cosmicdreams commentedrerolled with name change for file and function to PagerTest as per aspillicious's request. Also using git format-path here.
Comment #3
cosmicdreams CreditAttribution: cosmicdreams commentedsecond try to do the additional cleanup AND create one file with the format-patch.
Comment #5
cosmicdreams CreditAttribution: cosmicdreams commented#3: 0001-Pager-PSR-0.patch queued for re-testing.
Comment #7
aspilicious CreditAttribution: aspilicious commentedadd
use SimpleXMLElement;
on top of the file and everything will be green.
Comment #8
cosmicdreams CreditAttribution: cosmicdreams commentedWow, did my first rebase -i. That was an educational experience. Anyway here's a new patch for the system to test.
Comment #9
cosmicdreams CreditAttribution: cosmicdreams commentedComment #10
RobLoachWell done!
Comment #11
catch#8: 0001-Pager-PSR-0.patch queued for re-testing.
Comment #13
aspilicious CreditAttribution: aspilicious commentedRerolled
Comment #14
RobLoachIf we were smart, we'd coordinate these patches without needing a reroll for system.info all the time :-) .
Comment #15
catchFrom now on I'm going to just ignore system.info hunks if they don't apply (or if they're not there at all), and we can nuke those at the end all at once.
Comment #16
catchThanks! Committe/pushed.