Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in lock.test over to PSR-0.

CommentFileSizeAuthor
#7 1598586.patch1.19 KBRobLoach
#4 1598586.patch1.15 KBRobLoach
#1 15985386.patch748 bytesRobLoach
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Active » Needs review
FileSize
15985386.patch748 bytes

lock.test only have one test, so I'm not sure it needs its own Lock namespace. What do you think?

Status: Needs review » Needs work

The last submitted patch, 15985386.patch, failed testing.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented

Mhh ... not sure about that and why the tests are failing. Either way the old file[] entry has to be removed from the .info file.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1598586.patch1.15 KB

Interesting indeed.

Niklas Fiekas’s picture

Niklas Fiekas CreditAttribution: Niklas Fiekas commented
Status: Needs review » Reviewed & tested by the community

This one looks good to me. Also we don't need lower thresholds for rename detection.

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Needs work

This needs a quick reroll -- system.info has changed and I can't use git apply to apply the patch in #4. (The patch utility doesn't work well with renames in my recent experience.)

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs work » Needs review
FileSize
1598586.patch1.19 KB
aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

Good

jhodgdon’s picture

jhodgdon
she/her
Primary language English
CreditAttribution: jhodgdon commented
Status: Reviewed & tested by the community » Fixed

Thanks! Committed to 8.x.

Automatically closed -- issue fixed for 2 weeks with no activity.