Convert common.test to PSR-0 [#1598564]

Based on discussions in #1593058: Remove system.info's files[] entry, we are to move the tests in common.test over to PSR-0.

Comment	File	Size	Author
#10	1598564-common-tests-psr-0-10.patch	250.63 KB	Niklas Fiekas
#10
#8	1598564-common-tests-psr-0-8.patch	250.63 KB	Niklas Fiekas
#8
#6	1598564-common-tests-psr-0-6-mergediff.txt	2.26 KB	Niklas Fiekas
#6	1598564-common-tests-psr-0-6-interdiff.txt	4 KB	Niklas Fiekas
#6	1598564-to-be-manually-merged.txt	2.11 KB	Niklas Fiekas
#6	1598564-common-tests-psr-0-6.patch	253.17 KB	Niklas Fiekas
#6
#4	1598564-common-tests-psr-0-4.patch	250.6 KB	Niklas Fiekas
#4
#4	1598564-common-tests-psr-0-4-interdiff.txt	3.48 KB	Niklas Fiekas
#2	1598564-common-tests-psr-0-2.patch	250.59 KB	Niklas Fiekas
#2
#2	1598564-common-tests-psr-0-2-low-copy-thresholds.txt	2.01 MB	Niklas Fiekas

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

Niklas Fiekas CreditAttribution: Niklas Fiekas commented 29 May 2012 at 09:43

Assigned:

Unassigned

» Niklas Fiekas

Doing this now.

File	Size
1598564-common-tests-psr-0-2-low-copy-thresholds.txt	2.01 MB
1598564-common-tests-psr-0-2.patch	250.59 KB

I have also attached a version of the patch with much lower thresholds for rename and copy detection. That makes for a much bigger patch, but shows most of the code is directly coming from common.test.

Edit: I noticed that even 2% similarity index are not enough for the smaller tests. git blame -C would be an alternative.

Comment #3

29 May 2012 at 11:03

Status:

Needs review

» Needs work

The last submitted patch, 1598564-common-tests-psr-0-2.patch, failed testing.

Comment #4

Niklas Fiekas CreditAttribution: Niklas Fiekas commented 29 May 2012 at 14:22

Status:

Needs work

» Needs review

File	Size
1598564-common-tests-psr-0-4-interdiff.txt	3.48 KB
1598564-common-tests-psr-0-4.patch	250.6 KB

Some instances of stdClass() had to be prefixed with \.

Comment #5

aspilicious CreditAttribution: aspilicious commented 6 June 2012 at 08:31

Status:

Needs review

» Needs work

This probably will need a reroll with the recent commits. (I think it has to be checked manually)
And with recent discussion I would put "use stdClass" on top on the file without the \ prefix. (for now).

Comment #6

Niklas Fiekas CreditAttribution: Niklas Fiekas commented 6 June 2012 at 09:53

Status:

Needs work

» Needs review

File	Size
1598564-common-tests-psr-0-6.patch	253.17 KB

1598564-to-be-manually-merged.txt	2.11 KB
1598564-common-tests-psr-0-6-interdiff.txt	4 KB
1598564-common-tests-psr-0-6-mergediff.txt	2.26 KB

Reroll.

Attached is:

A full patch
The output of git log -p ..MERGE_HEAD -- common.test, showing the changes to common.test that had been done in the mean time and couldn't be automatically merged.
The output of git show after doing the merge.
The interdiff of the stdClass prefixing changes I did after the merge.