Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0

CommentFileSizeAuthor
#9 1591436-filter-tests-9.patch180.08 KBaspilicious
#7 1591436.patch177.77 KBRobLoach
#5 1591436-filter-tests-5.patch179.55 KBaspilicious
#3 1591436-filter-tests-3.patch179.54 KBaspilicious
#1 1591436-filter-tests-1.patch179.51 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
FileSize
1591436-filter-tests-1.patch179.51 KB

Status: Needs review » Needs work

The last submitted patch, 1591436-filter-tests-1.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1591436-filter-tests-3.patch179.54 KB

This could fix everything

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs review » Needs work 
+++ b/core/modules/filter/lib/Drupal/filter/Tests/FilterSecurityTest.phpundefined
@@ -0,0 +1,74 @@
+ * Definition of Drupal\filter\Tests\FilterAdminTest.

Wrong class name.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1591436-filter-tests-5.patch179.55 KB

Another try

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
FileSize
1591436.patch177.77 KB

Looks good, but camel-cased acronyms like "FilterCRUDTest" should brought down to "FilterCrudTest". See an example of it in Symfony.

Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs review » Reviewed & tested by the community

Looks good to go now.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
FileSize
1591436-filter-tests-9.patch180.08 KB

Reroll...

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Committed/pushed to 8.x, thanks!

Automatically closed -- issue fixed for 2 weeks with no activity.