Patch coming soon, see also #1513210: Meta: Start converting module provided classes to PSR-0

CommentFileSizeAuthor
#7 1591296-contextual-tests-7.patch1.87 KBaspilicious
#1 1591296-contextual-tests-1.patch1.87 KBaspilicious
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Active » Needs review
FileSize
1591296-contextual-tests-1.patch1.87 KB

Lets see...

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Issue tags: +PSR-0
Tor Arne Thune’s picture

Tor Arne Thune CreditAttribution: Tor Arne Thune commented
Status: Needs review » Reviewed & tested by the community

Ready to go.

chx’s picture

chx CreditAttribution: chx commented
Status: Reviewed & tested by the community » Needs review

Same as http://drupal.org/node/1591334#comment-6018710

chx’s picture

chx CreditAttribution: chx commented
Status: Needs review » Reviewed & tested by the community

Apparently I am wrong. Nevermind! git blame can follow history over this, it tracks content.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented
Status: Reviewed & tested by the community » Needs work 
+namespace Drupal\tracker\Tests;

Wrong module :)

(Which I'm guessing actually prevents these tests from ever running.)

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
FileSize
1591296-contextual-tests-7.patch1.87 KB

This should fix it :)

Status: Needs review » Needs work
Issue tags: -PSR-0

The last submitted patch, 1591296-contextual-tests-7.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review

#7: 1591296-contextual-tests-7.patch queued for re-testing.

Status: Needs review » Needs work

The last submitted patch, 1591296-contextual-tests-7.patch, failed testing.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs work » Needs review
Issue tags: +PSR-0

#7: 1591296-contextual-tests-7.patch queued for re-testing.

RobLoach’s picture

RobLoach
he/him
CreditAttribution: RobLoach commented
Status: Needs review » Reviewed & tested by the community

Easy!

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch commented
Status: Reviewed & tested by the community » Fixed

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

David_Rothstein’s picture

David_Rothstein CreditAttribution: David_Rothstein commented

Wrong module :)

(Which I'm guessing actually prevents these tests from ever running.)

Since that's pretty bad, I've written a patch at #1632364: Write tests to ensure that all classes in Drupal can actually be found by the autoloader that should help us catch these mistakes automatically in the future, rather than having to find them manually.