Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
I'll work on this one, as I'm already adding a PSR-0-ified test in #890790: deleting nodes does not delete their comments. and had to convert CommentHelperCase to PSR-0 as well over there.
Comment | File | Size | Author |
---|---|---|---|
#32 | 1588284-comment-tests-psr0-32.patch | 183.04 KB | aspilicious |
#31 | 1588284-comment-tests-psr0-21.patch | 179.99 KB | RobLoach |
#23 | 1588284-comment-tests-psr0-23.patch | 179.95 KB | Tor Arne Thune |
#23 | interdiff-1588284-21-23.txt | 449 bytes | Tor Arne Thune |
#21 | 1588284-comment-tests-psr0-21.patch | 179.99 KB | Tor Arne Thune |
Comments
Comment #1
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedUnassigning, as aspilicious beat me to it ;)
Comment #2
aspilicious CreditAttribution: aspilicious commentedThis normally should be green.
Comment #3
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedLeftover I suppose.
Also there is a place in user.test that references CommentHelperCase in the comments, so that should be changed.
Comment #4
aspilicious CreditAttribution: aspilicious commentedBut the other issue should fix that, so I'm leaving the reroll to you when the other issue is fixed :)
Comment #5
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedSure thing *writes a Post-It*
Comment #6
aspilicious CreditAttribution: aspilicious commentedAnd you should try to fix the warnings ;).
And those fails are rly weird, looks like a random bot failure :s
Comment #7
Tor Arne Thune CreditAttribution: Tor Arne Thune commented#2: 1588284-comment-tests-psr0-3.patch queued for re-testing.
Let's try a re-test. Maybe a random test failure again.
Comment #9
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedOkay, will deal with this later.
Comment #10
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedComment #12
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedRemoving unneeded use statements. Still have no clue about the failing upgrade tests.
Comment #13
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedOh, so the upgrade test failures were random bot failures. Great!
Comment #14
aspilicious CreditAttribution: aspilicious commentedActually that is'nt great. I think it's related to these psr-0 patches and a not cleared registry when upgrading. Hard to track down if it's random
Comment #15
BerdirThe use shouldn't be necessary because we're in the same namespace.
Powered by Dreditor.
Comment #16
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedMakes sense.
Comment #17
aspilicious CreditAttribution: aspilicious commentedLooks good now
Comment #18
aspilicious CreditAttribution: aspilicious commentedBut I'm going to postpone this on the other issue.
Comment #19
aspilicious CreditAttribution: aspilicious commentedI'll leave this one for you Tor Arne Thune :)
Comment #20
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedThanks, will re-roll it today :)
Comment #21
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedThis one should be good. Also changed CommentRSSTest to CommentRssTest (and its method to testCommentRss()) See #1591436: Convert filter tests to PSR-0 (comment #7) for the why.
Comment #22
aspilicious CreditAttribution: aspilicious commentedUse webtestbase isn't needed here
7 days to next Drupal core point release.
Comment #23
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedRemoved.
Comment #24
aspilicious CreditAttribution: aspilicious commentedGogogogo!
Comment #26
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedLooks like it's needed as setUp() calls WebTestBase::setUp() directly.
Shall we say #21 is RTBC?
Comment #27
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedOops, cross-post with System Message.
Comment #28
aspilicious CreditAttribution: aspilicious commentedThat doesn't sound ok...
I remember an issue about this....
Comment #29
Tor Arne Thune CreditAttribution: Tor Arne Thune commentedYes, there is an issue, but can't find it. I think we should leave that for the other issue.
Comment #30
aspilicious CreditAttribution: aspilicious commentedRTBC #21, we'll see what gets in first
Comment #31
RobLoachRe-uploading #21 to keep confusion down.
Comment #32
aspilicious CreditAttribution: aspilicious commentedReroll!
Comment #33
catchCommitted/pushed to 8.x, thanks!