Selectors clean-up: authorize.js

+++ b/core/misc/authorize.js
@@ -10,15 +10,17 @@
+    var $filetransfer = $('.filetransfer');

Why are none of the selectors using $(context).find() ?

I realize that the old code did not either, but that looks like a straight bug to me, which we can fix within the scope of "cleaning up selectors".

+++ b/core/misc/authorize.js
@@ -10,15 +10,17 @@
+    function handleSettingsChange () {

1) Only anonymous functions, i.e., literal "function" functions as in

foo = function () {
  ...

should use a space between "function" and "()".

See http://drupal.org/node/172169

2) Whenever moving embedded behavior logic into dedicated functions, we should ideally add them in the public scope on the behavior object (next to attach and detach methods), so they can be overridden by contributed modules, if necessary.

The authorize.js file wasn't ever loaded in D8, fixed that.

.connection-settings-update-filetransfer-default-wrapper has never been a valid CSS class in core.

As of the patch in #538660-107: Move update manager upgrade process into new authorize.php file (and make it actually work), there was a $form['connection_settings']['update_filetransfer_default'] and it had JS and CSS associated with it and its wrapper.

However, as of the massive rewrite in #538660-111: Move update manager upgrade process into new authorize.php file (and make it actually work), that form element was completely removed, but its CSS and JS were not.

So, we can remove that part and not worry about the floats.

I don't see what swapping an anonymous function for a named one gets us, when its only used once and it makes the code somewhat less readable, but I left that in for now.

Oh, by the way, to get to this page I enabled the system_test module and then went to http://example.com/system-test/authorize-init/system-test-auth

0) Any "clean-up" effort primarily targets "consistency", and I thus think that we should fix bogus selectors that are not using context correctly. Mind you, many novice JS coders are simply looking "How does Drupal core do it?" and open an arbitrary .js file to use that as template for their own code.

1) I can see how the previous docs were unclear and confusing. The detail about anonymous function literals was located in a separate section of the standards page. I've cleaned that up now: http://drupal.org/node/172169

2) I'm fine with omitting the named function in this case.

How's this for a JS cleanup?

Awesome, thanks!

This totally looks backportable to me.

Lovely.

Committed/pushed to 8.x, seems worth a try for backport.

The diffstat is smaller here because CommonJavaScriptTestCase doesn't exist in D7, so nothing else references authorize.js directly.

CommonJavaScriptTestCase is JavaScriptTestCase in D7. However, you're right in that it doesn't contain any references to authorize.js.

Backport looks good. Needs manual testing.

screwed up. Ignore this.

Removing tag per #15.