Support for Drupal 7 is ending on 5 January 2025—it’s time to migrate to Drupal 10! Learn about the many benefits of Drupal 10 and find migration tools in our resource center.
When the PHP memory limit is at 32M, the Drupal installer suggests I increase my memory limit to 32M.
Comment | File | Size | Author |
---|---|---|---|
#8 | test_equal_mem-1573556-8.patch | 1.71 KB | disasm |
#6 | drupal-test_equal_mem-1573556-6.patch | 1.71 KB | disasm |
#6 | interdiff.txt | 674 bytes | disasm |
#3 | drupal-test_equal_mem-1573556-3.patch | 1.58 KB | disasm |
Screen Shot 2012-05-12 at 12.40.08.png | 67.02 KB | justafish |
Comments
Comment #1
justafishPossibly related. Memory limit is set to 64M and turning on the Testing Framework results in
The testing framework requires the PHP memory limit to be at least 64M. The current value is 64M. Follow these steps to continue.
Comment #2
David_Rothstein CreditAttribution: David_Rothstein commentedLooks like this was caused by #1453984: Color module doesn't test for unlimited memory. when the drupal_check_memory_limit() function was added there.
Should be a simple one-line fix to that function, plus a test. (Note there are existing tests in system/Tests/Bootstrap/MiscUnitTest.php in Drupal 8.)
Probably this is a good Novice issue, actually... Adding the tag accordingly.
Comment #3
disasm CreditAttribution: disasm commentedAttached is a patch that fixes the bug where requested memory limit == available_memory. Also, a simple test is written that tests 30MB,30MB as params asserts true.
Comment #4
tim.plunkettLooks good. Also, I ran the tests locally without the fix and it failed correctly.
Comment #5
David_Rothstein CreditAttribution: David_Rothstein commentedLooks good to me too, but maybe we need to update this code comment also, to reflect the change?
Comment #6
disasm CreditAttribution: disasm commentedI changed the patch. Here's the patch and an interdiff.txt. I wasn't sure what to do stylistically about the line wrapping to the next line since adding or equal to increased the line to longer than 80 cols. Take a look at what I did and let me know if it needs changed at all.
Comment #7
tim.plunkettThere is a trailing space on the first line, and I believe the second line should be indented
Comment #8
disasm CreditAttribution: disasm commentedattached is patch
Comment #9
tim.plunkettThanks! Re-RTBC.
Comment #10
webchickLooks like a good bug fix, includes tests!
Committed and pushed to 8.x. Will need a re-roll for D7.
Comment #11
tim.plunkettThis should just be fixed correctly the first time in #1453984: Color module doesn't test for unlimited memory., as that wasn't committed yet. Thanks!