@todo

xmlrpc_message_parse() doesn't even use our custom PHP wrapper for xml_parser_create().

Related issues:
#110352: Support namespaces in drupal_xml_parser_create().
#279671: Update XML handling to use SimpleXML in PHP5

CommentFileSizeAuthor
#5 1569894-5.patch1.88 KBalexpott
drupal8.unicode-php5.0.patch4 KBsun
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

neclimdul’s picture

neclimdul
He/Him
CreditAttribution: neclimdul commented
Status: Needs review » Needs work 
+++ b/core/includes/unicode.incundefined
@@ -157,62 +157,6 @@ function unicode_requirements() {
-  // Check for UTF-8 byte order mark (PHP5's XML parser doesn't handle it).
-  if (!strncmp($data, "\xEF\xBB\xBF", 3)) {
-    $bom = TRUE;
-    $data = substr($data, 3);

:(

Version: 8.0.x-dev » 8.1.x-dev

Drupal 8.0.6 was released on April 6 and is the final bugfix release for the Drupal 8.0.x series. Drupal 8.0.x will not receive any further development aside from security fixes. Drupal 8.1.0-rc1 is now available and sites should prepare to update to 8.1.0.

Bug reports should be targeted against the 8.1.x-dev branch from now on, and new development or disruptive changes should be targeted against the 8.2.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

markdorison’s picture

markdorison
he/him
CreditAttribution: markdorison at Chromatic commented
Version: 8.1.x-dev » 8.3.x-dev
Issue summary: View changes

Patch no longer applies cleanly.

Version: 8.3.x-dev » 8.4.x-dev

Drupal 8.3.0-alpha1 will be released the week of January 30, 2017, which means new developments and disruptive changes should now be targeted against the 8.4.x-dev branch. For more information see the Drupal 8 minor version schedule and the Allowed changes during the Drupal 8 release cycle.

alexpott’s picture

alexpott
he/they
Primary language English
Location 🇪🇺🌍
CreditAttribution: alexpott at Chapter Three commented
Status: Needs work » Needs review
FileSize
1569894-5.patch1.88 KB

Added a test for #1.

gaurav.kapoor’s picture

gaurav.kapoor CreditAttribution: gaurav.kapoor at OpenSense Labs commented
Status: Needs review » Reviewed & tested by the community

#5 looks good , tested it , no error now in applying the patch. And since an xml_parser object has been created xmlrpc_message_parse() function will now use a wrapper.

catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented

  • catch committed d6724f5 on 8.4.x 
    Issue #1569894 by sun, alexpott: Update unicode.inc to PHP5
catch’s picture

catch
he/him
Primary language English
CreditAttribution: catch at Third and Grove commented
Status: Reviewed & tested by the community » Fixed

  • catch committed 41462f7 on 8.3.x 
    Issue #1569894 by sun, alexpott: Update unicode.inc to PHP5

(cherry...
borisson_’s picture

borisson_
Primary language Dutch
Location Mechelen, 🇧🇪
CreditAttribution: borisson_ as a volunteer and at Dazzle commented 
+++ b/core/includes/unicode.inc
@@ -74,6 +74,11 @@ function unicode_requirements() {
+ * @deprecated in Drupal 8.3.0 and will bre removed in Drupal 9.0.0. Use

/s/bre/be/

I don't think it makes sense to open a new issue, so just posting here; is that ok?

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.