In #1299424: Allow one module per directory and move system tests to core/modules/system, core/modules/simpletest/tests/database_test.test was moved to core/modules/system/tests/modules/database_test/database_test.test, but system.info suggests that it should have been moved to core/modules/system/tests/database_test.test instead.

For this reason, the database tests do not show up admin/config/development/testing.

CommentFileSizeAuthor
#2 move-and-rename-database-tests-1558268-2.patch749 bytesBerdir
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Crell’s picture

Crell CreditAttribution: Crell commented

Can we fold #323802: Rename database_test.test to database.test for consistency in here, too? Pretty please?

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented
Status: Needs work » Needs review
FileSize
move-and-rename-database-tests-1558268-2.patch749 bytes

Yes, we can.

This should let the database tests re-appear. Nice catch.

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Hah, and suddenly we have 1300 test assertions more :p

sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented
Status: Needs review » Reviewed & tested by the community

Thanks!

Berdir’s picture

Berdir
Primary language German
Location Switzerland
CreditAttribution: Berdir commented

Make sure to apply the patch like this to to include the renamed file:

git apply --index move-and-rename-database-tests-1558268-2.patch
sun’s picture

sun
Primary language German
Location Karlsruhe
CreditAttribution: sun commented

Or when using the recommended .gitconfig just simply:

git a move-and-rename-database-tests-1558268-2.patch
webchick’s picture

webchick
she/they
Primary language English
Location Vancouver 🇨🇦
CreditAttribution: webchick commented
Status: Reviewed & tested by the community » Fixed

This seems like it falls under "just plain busted" so I think it's on the plate of things I can touch. :)

Committed and pushed to 8.x. Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.