Similiar to multiple issues we try to kill all implicit relationships between entity like tables, as it both fixes potential problems with fieldapi, but also for similar behavior everywhere.

CommentFileSizeAuthor
#6 1547726-6.patch1.59 KBdamiankloip
#1 1547726.patch1.58 KBdawehner
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Active » Needs review
FileSize
1547726.patch1.58 KB

So here is a small patch, which should work, but definitive needs manual testing.

So what has to be tested

* Don't apply the patch ... create a view with node_revision as base and add fields from node and node_revision
* Additional add a view with node as base and add fields from both as well.
* Once you have done this, try to apply the patch and see whether everything still works as expected.

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Needs review » Reviewed & tested by the community

Have just given this a good test, all works as expected. Views relationships are also fixed after the patch is applied.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Version: 7.x-3.x-dev » 8.x-3.x-dev
Status: Reviewed & tested by the community » Patch (to be ported)

Thanks for the review!

Committed to 7.x-3.x, this needs a port to 8.x-3.x :(

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented
Assigned: Unassigned » tim.plunkett
Status: Patch (to be ported) » Postponed

I'd like to postpone this on annotations.

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Postponed » Patch (to be ported)

Mh i don't see a reason why this needs annotations... this issue just changes node.views.inc :)

damiankloip’s picture

damiankloip CreditAttribution: damiankloip commented
Status: Patch (to be ported) » Needs review
FileSize
1547726-6.patch1.59 KB

Yep, I think we need to get this in to keep 7.x and 8.x synched.

aspilicious’s picture

aspilicious CreditAttribution: aspilicious commented
Status: Needs review » Reviewed & tested by the community

same

dawehner’s picture

dawehner
Primary language German
CreditAttribution: dawehner commented
Status: Reviewed & tested by the community » Fixed

This is committed

tim.plunkett’s picture

tim.plunkett
he/him
Primary language English
Location Philadelphia
CreditAttribution: tim.plunkett commented

Oh, I meant to post that on #1690146-4: Create a generic entity bundle filter, guess I did it on two tabs :)

Committed: http://drupalcode.org/project/views.git/commit/46674b7

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

This change breaks all existing views because all JOINS happen on VID field but previously was on NID

Follow-up issue #1321288: How to: make views get and display ALL revisions of a given content (now: views only gets the latest revision)

andypost’s picture

andypost
he/him
Primary language Russian
CreditAttribution: andypost commented

Actual fix to roll back regression and provide node_revision.nid field #1754354-8: Node revisions only displays latest revision