Usability: remove word 'settings' in blocks administration [#153594]

We are currently listing all themes in the blocks administration and for every theme we have a tab named 'themeX settings'. If someone has many themes installed/enabled the tabs are quickly getting confusing. I suggest to remove the word 'settings' from the title. It makes the list much clearer without loosing context. Attached is a 'micro' patch which removes the word 'settings' (and adds a missing '$form_state').

Comment	File	Size	Author
#2	block_settings_title2.patch	833 bytes	profix898
#2
	block_settings_title.patch	1003 bytes	profix898

Support from Acquia helps fund testing for Drupal Acquia logo

Comments

Comment #1

moshe weitzman CreditAttribution: moshe weitzman commented 22 June 2007 at 03:40

+1 to removing that word 'settings'.

but your change to block_admin_display() does not look right. it is called from block_menu() with: page arguments' => array('block_admin_display', $key),

that means that $key will be first arg. also, you can simplify $title in that menu declaration and eliminate 'title arguments'

Comment #2

profix898 CreditAttribution: profix898 commented 22 June 2007 at 09:06

File	Size
block_settings_title2.patch	833 bytes

OK. Simplified $title (and eliminated 'title arguments').

As for the change to block_admin_display(). I was not sure there either. $key should be the first arguments, yes, but actually it is not. $form_state is passed as first arguments and $key comes second. Without the 'fix' the themes in blocks administration dont switch, what means you cant configure blocks per theme (and it generates a warning). Might be a bug in the FAPI3 section though ... I removed that piece from the patch for now. Thanks.